From 620b6220c239370c419f61cfd776c05c60ec9b4e Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Tue, 8 Aug 2023 21:10:25 +0200 Subject: [PATCH] Optimize checks for DOMParentNode and DOMChildNode Because we check the list with dom_sanity_check_node_list_for_insertion() before dom_is_node_in_list(), then we don't have to check the object type anymore in dom_is_node_in_list(), because dom_sanity_check_node_list_for_insertion() will have already done that. Closes GH-11914. --- ext/dom/parentnode.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ext/dom/parentnode.c b/ext/dom/parentnode.c index fe928797a1d..8b225d75c92 100644 --- a/ext/dom/parentnode.c +++ b/ext/dom/parentnode.c @@ -128,12 +128,8 @@ static bool dom_is_node_in_list(const zval *nodes, uint32_t nodesc, const xmlNod { for (uint32_t i = 0; i < nodesc; i++) { if (Z_TYPE(nodes[i]) == IS_OBJECT) { - const zend_class_entry *ce = Z_OBJCE(nodes[i]); - - if (instanceof_function(ce, dom_node_class_entry)) { - if (dom_object_get_node(Z_DOMOBJ_P(nodes + i)) == node_to_find) { - return true; - } + if (dom_object_get_node(Z_DOMOBJ_P(nodes + i)) == node_to_find) { + return true; } } }