From 00f9c5eeb4b4c5215e7a6a98b4ce5f7c0501c385 Mon Sep 17 00:00:00 2001 From: Ilija Tovilo Date: Fri, 8 Mar 2024 19:10:28 +0100 Subject: [PATCH] Remove MAP_JIT flag This flag is supposed to go on the flags parameter, rather than prot. Moreover, this flag is no longer needed because the JIT does not set RWX without ZTS, and JIT+ZTS has been disabled on macOS with Apple Silicon. Closes GH-13638 --- ext/opcache/shared_alloc_mmap.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ext/opcache/shared_alloc_mmap.c b/ext/opcache/shared_alloc_mmap.c index 33727d0da65..6f01f1d631b 100644 --- a/ext/opcache/shared_alloc_mmap.c +++ b/ext/opcache/shared_alloc_mmap.c @@ -180,9 +180,6 @@ static int create_segments(size_t requested_size, zend_shared_segment ***shared_ #ifdef PROT_MAX flags |= PROT_MAX(PROT_READ | PROT_WRITE | PROT_EXEC); #endif -#ifdef MAP_JIT - flags |= MAP_JIT; -#endif #if (defined(__linux__) || defined(__FreeBSD__)) && (defined(__x86_64__) || defined (__aarch64__)) && !defined(__SANITIZE_ADDRESS__) void *hint = find_prefered_mmap_base(requested_size); if (hint != MAP_FAILED) {