1
0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00

[skip ci] Remove obsolete guideline how to comment out code (#14621)

This can lead to undefined warnings when building with -Wundef and using
undefined FOO macro in #if condition. Also such code disabling should
not be encouraged exactly.
This commit is contained in:
Peter Kokot
2024-06-24 20:37:42 +02:00
committed by GitHub
parent ff58a7f624
commit 5236551776

View File

@@ -55,11 +55,6 @@ rewritten to comply with these rules.
the source. Although the `PHP_*` macros are mostly aliased to the `ZEND_*`
macros it gives a better understanding on what kind of macro you're calling.
1. When commenting out code using a `#if` statement, do NOT use `0` only.
Instead, use `"<git username here>_0"`. For example, `#if FOO_0`,
where `FOO` is your git user `foo`. This allows easier tracking of why
code was commented out, especially in bundled libraries.
1. Do not define functions that are not available. For instance, if a library is
missing a function, do not define the PHP version of the function, and do
not raise a run-time error about the function not existing. End users should