From 331e6ae548e7552169f494148fdc6fa0a906ddfb Mon Sep 17 00:00:00 2001
From: Niels Dossche <7771979+ndossche@users.noreply.github.com>
Date: Wed, 5 Nov 2025 20:13:32 +0100
Subject: [PATCH] tidy: Avoid some work when creating attributes (#20390)

We know these can't be numeric strings, so directly use the hash table
APIs. Also use ZVAL_STRING_FAST because many attributes are 0/1 chars
long.
---
 ext/tidy/tidy.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ext/tidy/tidy.c b/ext/tidy/tidy.c
index 63820d1a307..54028537d39 100644
--- a/ext/tidy/tidy.c
+++ b/ext/tidy/tidy.c
@@ -616,12 +616,14 @@ static void tidy_add_node_default_properties(PHPTidyObj *obj)
 		do {
 			const char *attr_name = tidyAttrName(tempattr);
 			if (attr_name) {
+				zval value;
 				const char *val = tidyAttrValue(tempattr);
 				if (val) {
-					add_assoc_string(&attribute, attr_name, val);
+					ZVAL_STRING_FAST(&value, val);
 				} else {
-					add_assoc_str(&attribute, attr_name, zend_empty_string);
+					ZVAL_EMPTY_STRING(&value);
 				}
+				zend_hash_str_add_new(Z_ARRVAL(attribute), attr_name, strlen(attr_name), &value);
 			}
 		} while((tempattr = tidyAttrNext(tempattr)));
 	} else {