php/archived-php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2026-03-24 00:02:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix GH-20890: Segfault in zval_undefined_cv with non-simple property hook with minimal tracing JIT"

Browse Source 
This reverts commit 57c62eb2b3.
This commit is contained in:
Niels Dossche
2026-01-20 21:05:26 +01:00
parent 57c62eb2b3
commit 32c0245531
3 changed files with 0 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
NEWS
View File

@@ -25,10 +25,6 @@ PHP NEWS
. Fixed bug GH-20836 (Stack overflow in mb_convert_variables with . Fixed bug GH-20836 (Stack overflow in mb_convert_variables with
recursive array references). (alexandre-daubois) recursive array references). (alexandre-daubois)
- Opcache:
. Fixed bug GH-20890 (Segfault in zval_undefined_cv with non-simple
property hook with minimal tracing JIT). (ndossche)
- Phar: - Phar:
. Fixed bug GH-20882 (buildFromIterator breaks with missing base directory). . Fixed bug GH-20882 (buildFromIterator breaks with missing base directory).
(ndossche) (ndossche)

8
ext/opcache/jit/zend_jit_trace.c
View File

@@ -328,14 +328,6 @@ static int zend_jit_trace_may_exit(const zend_op_array *op_array, const zend_op
// TODO: recompilation may change target ??? // TODO: recompilation may change target ???
return 0; return 0;
#endif #endif
case ZEND_FETCH_OBJ_R:
if (opline->op2_type == IS_CONST) {
const zend_class_entry *ce = opline->op1_type == IS_UNUSED ? op_array->scope : NULL;
if (!ce || !(ce->ce_flags & ZEND_ACC_FINAL) || ce->num_hooked_props > 0) {
return 1;
}
}
break;
case ZEND_RETURN_BY_REF: case ZEND_RETURN_BY_REF:
case ZEND_RETURN: case ZEND_RETURN:
/* return */ /* return */

37
ext/opcache/tests/jit/gh20890.phpt
View File

@@ -1,37 +0,0 @@
--TEST--
GH-20890 (Segfault in zval_undefined_cv with non-simple property hook with minimal tracing JIT)
--CREDITS--
Moonster8282
--EXTENSIONS--
opcache
--INI--
opcache.jit=1251
--FILE--
<?php
class HookJIT {
private int $readCount = 0;
public int $computed {
get {
$this->readCount++;
return $this->readCount * 2;
}
}
}
function hook_hot_path($obj, $iterations) {
$sum = 0;
for ($i = 0; $i < $iterations; $i++) {
$sum += $obj->computed;
}
return $sum;
}
echo "Testing property hook in hot path...\n";
$obj = new HookJIT();
$result = hook_hot_path($obj, 100);
echo "Result: $result\n";
?>
--EXPECT--
Testing property hook in hot path...
Result: 10100