From 183cd048f18fa4b04fb30448a84a54cee80a2491 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Fri, 17 Mar 2017 13:34:18 +0100 Subject: [PATCH] Fix AST start lineno for list nodes If the node is initialized with children, check if a child has a lower start lineno, similar to what we do for fixed-sized nodes as well. --- Zend/zend_ast.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Zend/zend_ast.c b/Zend/zend_ast.c index c97e1c4ffe0..b55d0e8a3b9 100644 --- a/Zend/zend_ast.c +++ b/Zend/zend_ast.c @@ -155,7 +155,14 @@ ZEND_API zend_ast *zend_ast_create_list(uint32_t init_children, zend_ast_kind ki uint32_t i; va_start(va, kind); for (i = 0; i < init_children; ++i) { - ast = zend_ast_list_add(ast, va_arg(va, zend_ast *)); + zend_ast *child = va_arg(va, zend_ast *); + ast = zend_ast_list_add(ast, child); + if (child != NULL) { + uint32_t lineno = zend_ast_get_lineno(child); + if (lineno < ast->lineno) { + ast->lineno = lineno; + } + } } va_end(va); }