From 2958cdc0b53bc320407b73ed74b3ab010f4296bf Mon Sep 17 00:00:00 2001 From: Xinchen Hui Date: Mon, 20 Jan 2020 12:33:37 +0800 Subject: [PATCH] Let's make this safer from maliciously crafted filename --- ext/opcache/ZendAccelerator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/opcache/ZendAccelerator.c b/ext/opcache/ZendAccelerator.c index bd2b665b06c..263336d99e2 100644 --- a/ext/opcache/ZendAccelerator.c +++ b/ext/opcache/ZendAccelerator.c @@ -3216,7 +3216,7 @@ static size_t preload_try_strip_filename(zend_string *filename) { if (ZSTR_LEN(filename) > sizeof(" eval()'d code") && *(ZSTR_VAL(filename) + ZSTR_LEN(filename) - sizeof(" eval()'d code")) == ':') { const char *cfilename = ZSTR_VAL(filename); - size_t cfilenamelen = ZSTR_LEN(filename) - sizeof(" eval()'d code") - 2 /* :*/; + size_t cfilenamelen = ZSTR_LEN(filename) - sizeof(" eval()'d code") - 1 /*:*/; while (cfilenamelen && cfilename[--cfilenamelen] != '('); return cfilenamelen; }