From 290fb920f2bd07b328ae6fd4f48ae83ec065375a Mon Sep 17 00:00:00 2001
From: Gina Peter Bnayard <girgias@php.net>
Date: Fri, 13 Sep 2024 13:30:10 +0200
Subject: [PATCH] ext/phar: Mark constant string as static const

---
 ext/phar/phar.c | 3 ++-
 ext/phar/tar.c  | 5 +++--
 ext/phar/zip.c  | 2 +-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/ext/phar/phar.c b/ext/phar/phar.c
index ebeef6a9afe..000a52435f9 100644
--- a/ext/phar/phar.c
+++ b/ext/phar/phar.c
@@ -2531,7 +2531,8 @@ int phar_flush(phar_archive_data *phar, char **error) {
  */
 int phar_flush_ex(phar_archive_data *phar, zend_string *user_stub, bool is_default_stub, char **error) /* {{{ */
 {
-	char halt_stub[] = "__HALT_COMPILER();";
+	static const char halt_stub[] = "__HALT_COMPILER();";
+
 	zend_string *newstub;
 	phar_entry_info *entry, *newentry;
 	size_t halt_offset;
diff --git a/ext/phar/tar.c b/ext/phar/tar.c
index 2711be3683b..024d35b0b35 100644
--- a/ext/phar/tar.c
+++ b/ext/phar/tar.c
@@ -957,14 +957,15 @@ static int phar_tar_setupmetadata(zval *zv, void *argument) /* {{{ */
 
 int phar_tar_flush(phar_archive_data *phar, zend_string *user_stub, bool is_default_stub, char **error) /* {{{ */
 {
-	phar_entry_info entry = {0};
 	static const char newstub[] = "<?php // tar-based phar archive stub file\n__HALT_COMPILER();";
+	static const char halt_stub[] = "__HALT_COMPILER();";
+
+	phar_entry_info entry = {0};
 	php_stream *oldfile, *newfile;
 	bool must_close_old_file = false;
 	size_t signature_length;
 	struct _phar_pass_tar_info pass;
 	char *buf, *signature, sigbuf[8];
-	char halt_stub[] = "__HALT_COMPILER();";
 
 	entry.flags = PHAR_ENT_PERM_DEF_FILE;
 	entry.timestamp = time(NULL);
diff --git a/ext/phar/zip.c b/ext/phar/zip.c
index 87d74f91cf4..e1ee8eddc69 100644
--- a/ext/phar/zip.c
+++ b/ext/phar/zip.c
@@ -1254,7 +1254,7 @@ static int phar_zip_applysignature(phar_archive_data *phar, struct _phar_zip_pas
 int phar_zip_flush(phar_archive_data *phar, zend_string *user_stub, bool is_default_stub, char **error) /* {{{ */
 {
 	static const char newstub[] = "<?php // zip-based phar archive stub file\n__HALT_COMPILER();";
-	char halt_stub[] = "__HALT_COMPILER();";
+	static const char halt_stub[] = "__HALT_COMPILER();";
 
 	php_stream *oldfile;
 	bool must_close_old_file = false;