1
0
mirror of https://github.com/php/phd.git synced 2026-03-24 07:02:07 +01:00

15 Commits

Author SHA1 Message Date
Máté Kocsis
0e43594305 Revert "Add explicit type declarations to class constants (PHP 8.3+) (#215)"
This reverts commit c65199393a.
2026-03-04 08:43:09 +01:00
Louis-Arnaud
c65199393a Add explicit type declarations to class constants (PHP 8.3+) (#215)
### Motivation
- Enhances type safety and static analysis.
- Makes code intent clearer.
- Prepares PhD for PHP 8.4 compatibility and future strictness.

### Scope
- Added types such as `int`, `string`, `bool`, or `array` to class constants.
- Example:
    Before:
        `public const FORMAT_HTML = 1;`
        `public const NAME = 'PhD';`
    After:
        `public const int FORMAT_HTML = 1;`
        `public const string NAME = 'PhD';`

### Impact
-  No runtime behavior change.
-  Fully backward compatible with PHP 8.3+.
- ⚙️ Code clarity and safety improvement only.
- Updated `composer.json` to indicate PHP 8.3 requirement
- Removed 8.1 and 8.2 CI pipelines

### References
- [PHP 8.3: Typed class constants RFC](https://wiki.php.net/rfc/typed_class_constants)
- [PHP manual: Class constants](https://www.php.net/manual/en/language.oop5.constants.php)

---------

Co-authored-by: lacatoire <louis-arnaud.catoire@external.drivalia.com>
2026-02-05 20:45:10 +00:00
Louis-Arnaud
61ad3e7cb0 Support MathML (mml:*) elements for XHTML rendering (#236)
Closes #172
2026-02-05 17:04:33 +00:00
haszi
15284136ff Separate regular PhD output from error handling (#176)
- Move error handling code into a class and remove PhD message output handling from it.
- Introduce a new class to handle PhD message output.
- Make the implicit dependency on the output functionality of classes explicit.
- Update PEAR package.xml.
- Fix tests.
- Use proper variadic parameters
- Use class constants
- Use first-class callable syntax

---------

Co-authored-by: haszi <haszika80@gmail.com>
2024-11-10 17:57:05 +00:00
haszi
5b52aac2fb Refactor Reader
Add method parameter and return types.
Make readNode method private.
Change equality to identity comparison for string.
Remove unnecessary comments and empty lines.
Add test.
2024-04-16 11:13:06 +01:00
haszi
e5b8bf35a9 Remove file ending comment blocks (#92)
Co-authored-by: haszi <haszika80@gmail.com>
2024-02-08 12:46:21 +00:00
Peter Kokot
3564283891 Sync final newlines
This patch adds some missing newlines and trims multiple redundant
newlines into a single newline.

According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
2018-10-02 06:23:33 +02:00
Sobak
aecae4e2c3 Eliminate $ comments 2015-03-09 06:20:39 +01:00
Hannes Magnusson
9a8b64dc19 Do not skip over nodes when indexing their content 2012-06-09 14:09:29 +01:00
Hannes Magnusson
f93275bee2 Remove useless method calls, safes us ~5 seconds :] 2011-04-23 17:45:52 +00:00
Moacir de Oliveira Miranda Júnior
f9dcc25027 fixing page titles 2009-08-05 12:59:12 +00:00
Hannes Magnusson
9bacdbd09b - Add missing $Id$ tags and vim modelines
- Remove useless closing tags
2009-07-30 16:56:01 +00:00
Moacir de Oliveira Miranda Júnior
409c65ce54 fixing class names bugs 2009-06-20 06:58:48 +00:00
Christian Weiske
ff5cc4ebcf Add namespace in (hopefully) every class. This is fully untested!
I probably confused Format_Legacy with Format in some files.
2009-06-19 21:48:54 +00:00
Moacir de Oliveira Miranda Júnior
b7909c572d Merging from Enterprise 2009-06-13 11:18:08 +00:00