mirror of
https://github.com/php/frankenphp.git
synced 2026-03-24 00:52:11 +01:00
Closes #83 #880 #1286. Working patch for Windows support. Supports linking to the [official PHP release (TS version)](https://www.php.net/downloads.php). Includes some work from #1286 (thanks @TenHian!!) This patch allows using Visual Studio to compile the cgo code. To do so, it must be compiled with Go 1.26 (RC) with the following setup: ```powershell winget install -e --id Microsoft.VisualStudio.2022.Community --override "--passive --wait --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.Llvm.Clang --includeRecommended" winget install -e --id GoLang.Go $env:PATH += ';C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\Llvm\bin' cd c:\ gh repo clone microsoft/vcpkg .\vcpkg\bootstrap-vcpkg.bat .\vcpkg\vcpkg install pthreads brotli # build watcher Invoke-WebRequest -Uri "https://github.com/e-dant/watcher/releases/download/0.14.3/x86_64-pc-windows-msvc.tar" -OutFile "$env:TEMP\watcher.tar" tar -xf "$env:TEMP\watcher.tar" -C C:\ Rename-Item -Path "C:\x86_64-pc-windows-msvc" -NewName "watcher-x86_64-pc-windows-msvc" Remove-Item "$env:TEMP\watcher.tar" # download php Invoke-WebRequest -Uri "https://downloads.php.net/~windows/releases/archives/php-8.5.1-Win32-vs17-x64.zip" -OutFile "$env:TEMP\php.zip" Expand-Archive -Path "$env:TEMP\php.zip" -DestinationPath "C:\" Remove-Item "$env:TEMP\php.zip" # download php development package Invoke-WebRequest -Uri "https://downloads.php.net/~windows/releases/archives/php-devel-pack-8.5.1-Win32-vs17-x64.zip" -OutFile "$env:TEMP\php-devel.zip" Expand-Archive -Path "$env:TEMP\php-devel.zip" -DestinationPath "C:\" Remove-Item "$env:TEMP\php-devel.zip" $env:GOTOOLCHAIN = 'go1.26rc1' $env:CC = 'clang' $env:CXX = 'clang++' $env:CGO_CFLAGS = "-I$env:C:\vcpkg\installed\x64-windows\include -IC:\watcher-x86_64-pc-windows-msvc -IC:\php-8.5.1-devel-vs17-x64\include -IC:\php-8.5.1-devel-vs17-x64\include\main -IC:\php-8.5.1-devel-vs17-x64\include\TSRM -IC:\php-8.5.1-devel-vs17-x64\include\Zend -IC:\php-8.5.1-devel-vs17-x64\include\ext" $env:CGO_LDFLAGS = '-LC:\vcpkg\installed\x64-windows\lib -lbrotlienc -LC:\watcher-x86_64-pc-windows-msvc -llibwatcher-c -LC:\php-8.5.1-Win32-vs17-x64 -LC:\php-8.5.1-devel-vs17-x64\lib -lphp8ts -lphp8embed' # clone frankenphp and build git clone -b windows https://github.com/php/frankenphp.git cd frankenphp\caddy\frankenphp go build -ldflags '-extldflags="-fuse-ld=lld"' -tags nowatcher,nobadger,nomysql,nopgx # Tests $env:PATH += ";$env:VCPKG_ROOT\installed\x64-windows\bin;C:\watcher-x86_64-pc-windows-msvc";C:\php-8.5.1-Win32-vs17-x64" "opcache.enable=0`r`nopcache.enable_cli=0" | Out-File -Encoding ascii php.ini $env:PHPRC = Get-Location go test -ldflags '-extldflags="-fuse-ld=lld"' -tags nowatcher,nobadger,nomysql,nopgx . ``` TODO: - [x] Fix remaining skipped tests (scaling and watcher) - [x] Test if the watcher mode works as expected - [x] Automate the build with GitHub Actions --------- Signed-off-by: Marc <m@pyc.ac> Co-authored-by: Kévin Dunglas <kevin@dunglas.dev> Co-authored-by: DubbleClick <m@pyc.ac>
390 lines
9.2 KiB
Go
390 lines
9.2 KiB
Go
//go:build !nowatcher
|
|
|
|
package watcher
|
|
|
|
import (
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/e-dant/watcher/watcher-go"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func normalizePath(t *testing.T, path string) string {
|
|
t.Helper()
|
|
|
|
if filepath.Separator == '/' {
|
|
return path
|
|
}
|
|
|
|
path = filepath.FromSlash(path)
|
|
if strings.HasPrefix(path, "\\") {
|
|
path = "C:\\" + path[1:]
|
|
}
|
|
|
|
return path
|
|
}
|
|
|
|
func newPattern(t *testing.T, value string) pattern {
|
|
t.Helper()
|
|
|
|
p := pattern{value: normalizePath(t, value)}
|
|
require.NoError(t, p.parse())
|
|
|
|
return p
|
|
}
|
|
|
|
func TestDisallowOnEventTypeBiggerThan3(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
w := newPattern(t, "/some/path")
|
|
|
|
assert.False(t, w.allowReload(&watcher.Event{PathName: "/some/path/watch-me.php", EffectType: watcher.EffectTypeOwner}))
|
|
}
|
|
|
|
func TestDisallowOnPathTypeBiggerThan2(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
w := newPattern(t, "/some/path")
|
|
|
|
assert.False(t, w.allowReload(&watcher.Event{PathName: "/some/path/watch-me.php", PathType: watcher.PathTypeSymLink}))
|
|
}
|
|
|
|
func TestWatchesCorrectDir(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path", "/path"},
|
|
{"/path/", "/path"},
|
|
{"/path/**/*.php", "/path"},
|
|
{"/path/*.php", "/path"},
|
|
{"/path/*/*.php", "/path"},
|
|
{"/path/?path/*.php", "/path"},
|
|
{"/path/{dir1,dir2}/**/*.php", "/path"},
|
|
{".", relativeDir(t, "")},
|
|
{"./", relativeDir(t, "")},
|
|
{"./**", relativeDir(t, "")},
|
|
{"..", relativeDir(t, "/..")},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
hasDir(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidRecursiveDirectories(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
file string
|
|
}{
|
|
{"/path", "/path/file.php"},
|
|
{"/path", "/path/subpath/file.php"},
|
|
{"/path/", "/path/subpath/file.php"},
|
|
{"/path**", "/path/subpath/file.php"},
|
|
{"/path/**", "/path/subpath/file.php"},
|
|
{"/path/**/", "/path/subpath/file.php"},
|
|
{".", relativeDir(t, "file.php")},
|
|
{".", relativeDir(t, "subpath/file.php")},
|
|
{"./**", relativeDir(t, "subpath/file.php")},
|
|
{"..", relativeDir(t, "subpath/file.php")},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternMatch(t, d.pattern, d.file)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestInvalidRecursiveDirectories(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path", "/other/file.php"},
|
|
{"/path/**", "/other/file.php"},
|
|
{".", "/other/file.php"},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternNotMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidNonRecursiveFilePatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/*.php", "/file.php"},
|
|
{"/path/*.php", "/path/file.php"},
|
|
{"/path/?ile.php", "/path/file.php"},
|
|
{"/path/file.php", "/path/file.php"},
|
|
{"*.php", relativeDir(t, "file.php")},
|
|
{"./*.php", relativeDir(t, "file.php")},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestInValidNonRecursiveFilePatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path/*.txt", "/path/file.php"},
|
|
{"/path/*.php", "/path/subpath/file.php"},
|
|
{"/*.php", "/path/file.php"},
|
|
{"*.txt", relativeDir(t, "file.php")},
|
|
{"*.php", relativeDir(t, "subpath/file.php")},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternNotMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidRecursiveFilePatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path/**/*.php", "/path/file.php"},
|
|
{"/path/**/*.php", "/path/subpath/file.php"},
|
|
{"/path/**/?ile.php", "/path/subpath/file.php"},
|
|
{"/path/**/file.php", "/path/subpath/file.php"},
|
|
{"**/*.php", relativeDir(t, "file.php")},
|
|
{"**/*.php", relativeDir(t, "subpath/file.php")},
|
|
{"./**/*.php", relativeDir(t, "subpath/file.php")},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestInvalidRecursiveFilePatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path/**/*.txt", "/path/file.php"},
|
|
{"/path/**/*.txt", "/other/file.php"},
|
|
{"/path/**/*.txt", "/path/subpath/file.php"},
|
|
{"/path/**/?ilm.php", "/path/subpath/file.php"},
|
|
{"**/*.php", "/other/file.php"},
|
|
{".**/*.php", "/other/file.php"},
|
|
{"./**/*.php", "/other/file.php"},
|
|
{"/a/**/very/long/path.php", "/a/short.php"},
|
|
{"", ""},
|
|
{"/a/**/b/c/d/**/e.php", "/a/x/e.php"},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternNotMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidDirectoryPatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path/*/*.php", "/path/subpath/file.php"},
|
|
{"/path/*/*/*.php", "/path/subpath/subpath/file.php"},
|
|
{"/path/?/*.php", "/path/1/file.php"},
|
|
{"/path/**/vendor/*.php", "/path/vendor/file.php"},
|
|
{"/path/**/vendor/*.php", "/path/subpath/vendor/file.php"},
|
|
{"/path/**/vendor/**/*.php", "/path/vendor/file.php"},
|
|
{"/path/**/vendor/**/*.php", "/path/subpath/subpath/vendor/subpath/subpath/file.php"},
|
|
{"/path/**/vendor/*/*.php", "/path/subpath/subpath/vendor/subpath/file.php"},
|
|
{"/path*/path*/*", "/path1/path2/file.php"},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestInvalidDirectoryPatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path/subpath/*.php", "/path/other/file.php"},
|
|
{"/path/*/*.php", "/path/subpath/subpath/file.php"},
|
|
{"/path/?/*.php", "/path/subpath/file.php"},
|
|
{"/path/*/*/*.php", "/path/subpath/file.php"},
|
|
{"/path/*/*/*.php", "/path/subpath/subpath/subpath/file.php"},
|
|
{"/path/**/vendor/*.php", "/path/subpath/vendor/subpath/file.php"},
|
|
{"/path/**/vendor/*.php", "/path/subpath/file.php"},
|
|
{"/path/**/vendor/**/*.php", "/path/subpath/file.php"},
|
|
{"/path/**/vendor/**/*.txt", "/path/subpath/vendor/subpath/file.php"},
|
|
{"/path/**/vendor/**/*.php", "/path/subpath/subpath/subpath/file.php"},
|
|
{"/path/**/vendor/*/*.php", "/path/subpath/vendor/subpath/subpath/file.php"},
|
|
{"/path*/path*", "/path1/path1/file.php"},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternNotMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidCurlyBracePatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
file string
|
|
}{
|
|
{"/path/*.{php}", "/path/file.php"},
|
|
{"/path/*.{php,twig}", "/path/file.php"},
|
|
{"/path/*.{php,twig}", "/path/file.twig"},
|
|
{"/path/**/{file.php,file.twig}", "/path/subpath/file.twig"},
|
|
{"/path/{dir1,dir2}/file.php", "/path/dir1/file.php"},
|
|
{"/path/{dir1,dir2}/file.php", "/path/dir2/file.php"},
|
|
{"/app/{app,config,resources}/**/*.php", "/app/app/subpath/file.php"},
|
|
{"/app/{app,config,resources}/**/*.php", "/app/config/subpath/file.php"},
|
|
{"/path/{dir1,dir2}/{a,b}{a,b}.php", "/path/dir1/ab.php"},
|
|
{"/path/{dir1,dir2}/{a,b}{a,b}.php", "/path/dir2/aa.php"},
|
|
{"/path/{dir1,dir2}/{a,b}{a,b}.php", "/path/dir2/bb.php"},
|
|
{"/path/{dir1/test.php,dir2/test.php}", "/path/dir1/test.php"},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternMatch(t, d.pattern, d.file)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestInvalidCurlyBracePatterns(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := []struct {
|
|
pattern string
|
|
dir string
|
|
}{
|
|
{"/path/*.{php}", "/path/file.txt"},
|
|
{"/path/*.{php,twig}", "/path/file.txt"},
|
|
{"/path/{file.php,file.twig}", "/path/file.txt"},
|
|
{"/path/{dir1,dir2}/file.php", "/path/dir3/file.php"},
|
|
{"/path/{dir1,dir2}/**/*.php", "/path/dir1/subpath/file.txt"},
|
|
{"/path/{dir1,dir2}/{a,b}{a,b}.php", "/path/dir1/ac.php"},
|
|
{"/path/{}/{a,b}{a,b}.php", "/path/dir1/ac.php"},
|
|
{"/path/}dir{/{a,b}{a,b}.php", "/path/dir1/aa.php"},
|
|
}
|
|
|
|
for _, d := range data {
|
|
t.Run(d.pattern, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assertPatternNotMatch(t, d.pattern, d.dir)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAnAssociatedEventTriggersTheWatcher(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
w := newPattern(t, "/**/*.php")
|
|
w.events = make(chan eventHolder)
|
|
|
|
e := &watcher.Event{PathName: normalizePath(t, "/path/temporary_file"), AssociatedPathName: normalizePath(t, "/path/file.php")}
|
|
go w.handle(e)
|
|
|
|
assert.Equal(t, e, (<-w.events).event)
|
|
}
|
|
|
|
func relativeDir(t *testing.T, relativePath string) string {
|
|
t.Helper()
|
|
|
|
dir, err := filepath.Abs("./" + relativePath)
|
|
assert.NoError(t, err)
|
|
|
|
return dir
|
|
}
|
|
|
|
func hasDir(t *testing.T, p string, dir string) {
|
|
t.Helper()
|
|
|
|
w := newPattern(t, p)
|
|
|
|
assert.Equal(t, normalizePath(t, dir), w.value)
|
|
}
|
|
|
|
func assertPatternMatch(t *testing.T, p, fileName string) {
|
|
t.Helper()
|
|
|
|
w := newPattern(t, p)
|
|
|
|
assert.True(t, w.allowReload(&watcher.Event{PathName: normalizePath(t, fileName)}))
|
|
}
|
|
|
|
func assertPatternNotMatch(t *testing.T, p, fileName string) {
|
|
t.Helper()
|
|
|
|
w := newPattern(t, p)
|
|
|
|
assert.False(t, w.allowReload(&watcher.Event{PathName: normalizePath(t, fileName)}))
|
|
}
|