mirror of
https://github.com/php-win-ext/phpredis.git
synced 2026-03-25 09:32:08 +01:00
This relates to a previous hotfix for issue #379 where phpredis would time out if you sent an array of empty values. The reason it was timing out is that the argument count being sent wasn't reflecting any skipped items in the array (meaning redis was waiting for the rest of the command). I realized that the previous fix would still fail if you were to send some valid values, with invalid (null, empty string, etc) ones mixed in. Presently, we're just skipping invalid items in the array but there might be a case to issue a php_error_docref type warning when we encounter them, so the user can know that it happened. In addition, HMGET now uses a smart_str to build the command, which means the time it takes to build the key will scale in a linear fashion