From 86ecbb7a21947c27ae5b874dcdc60f76c705e020 Mon Sep 17 00:00:00 2001 From: fanjiapeng Date: Thu, 8 Nov 2018 11:19:25 +0800 Subject: [PATCH 1/2] Fix function close() return value --- redis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/redis.c b/redis.c index f829075..5862eec 100644 --- a/redis.c +++ b/redis.c @@ -1012,7 +1012,7 @@ PHP_METHOD(Redis, close) { RedisSock *redis_sock = redis_sock_get_connected(INTERNAL_FUNCTION_PARAM_PASSTHRU); - if (redis_sock && redis_sock_disconnect(redis_sock, 1 TSRMLS_CC)) { + if (redis_sock && redis_sock_disconnect(redis_sock, 1 TSRMLS_CC) == SUCCESS) { RETURN_TRUE; } RETURN_FALSE; From 2a1ef961a2fd6551798c63deceeada257fdac575 Mon Sep 17 00:00:00 2001 From: fanjiapeng Date: Thu, 8 Nov 2018 15:18:46 +0800 Subject: [PATCH 2/2] Close() Optimization --- redis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/redis.c b/redis.c index 5862eec..5242d97 100644 --- a/redis.c +++ b/redis.c @@ -1012,7 +1012,7 @@ PHP_METHOD(Redis, close) { RedisSock *redis_sock = redis_sock_get_connected(INTERNAL_FUNCTION_PARAM_PASSTHRU); - if (redis_sock && redis_sock_disconnect(redis_sock, 1 TSRMLS_CC) == SUCCESS) { + if (redis_sock_disconnect(redis_sock, 1 TSRMLS_CC) == SUCCESS) { RETURN_TRUE; } RETURN_FALSE;