From 77afcacf4fcd9e0ff413c20fd32ce552e172e8a4 Mon Sep 17 00:00:00 2001 From: Shivam Mathur Date: Tue, 16 Jul 2024 20:03:16 +0530 Subject: [PATCH] Use tagged version of php-sdk-binary-tools --- extension/BuildPhpExtension/private/Get-PhpSdk.ps1 | 5 +++-- php/BuildPhp/private/Get-PhpSdk.ps1 | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/extension/BuildPhpExtension/private/Get-PhpSdk.ps1 b/extension/BuildPhpExtension/private/Get-PhpSdk.ps1 index d190507..2cc9c96 100644 --- a/extension/BuildPhpExtension/private/Get-PhpSdk.ps1 +++ b/extension/BuildPhpExtension/private/Get-PhpSdk.ps1 @@ -7,7 +7,8 @@ function Get-PhpSdk { param ( ) begin { - $url = "https://github.com/php/php-sdk-binary-tools/archive/master.zip" + $sdkVersion = "2.3.0" + $url = "https://github.com/php/php-sdk-binary-tools/archive/php-sdk-$sdkVersion.zip" } process { Add-Type -Assembly "System.IO.Compression.Filesystem" @@ -16,7 +17,7 @@ function Get-PhpSdk { $currentDirectory = (Get-Location).Path $sdkZipFilePath = Join-Path $currentDirectory php-sdk.zip [System.IO.Compression.ZipFile]::ExtractToDirectory($sdkZipFilePath, $currentDirectory) - Rename-Item -Path php-sdk-binary-tools-master php-sdk + Rename-Item -Path php-sdk-binary-tools-php-sdk-$sdkVersion php-sdk $sdkDirectoryPath = Join-Path $currentDirectory php-sdk $sdkBinDirectoryPath = Join-Path $sdkDirectoryPath bin diff --git a/php/BuildPhp/private/Get-PhpSdk.ps1 b/php/BuildPhp/private/Get-PhpSdk.ps1 index 4cc7098..0a74ab3 100644 --- a/php/BuildPhp/private/Get-PhpSdk.ps1 +++ b/php/BuildPhp/private/Get-PhpSdk.ps1 @@ -7,12 +7,13 @@ function Get-PhpSdk { param ( ) begin { - $url = "https://github.com/php/php-sdk-binary-tools/archive/master.zip" + $sdkVersion = "2.3.0" + $url = "https://github.com/php/php-sdk-binary-tools/archive/php-sdk-$sdkVersion.zip" } process { Invoke-WebRequest $url -OutFile php-sdk.zip Expand-Archive -Path php-sdk.zip -DestinationPath . - Rename-Item -Path php-sdk-binary-tools-master php-sdk + Rename-Item -Path php-sdk-binary-tools-php-sdk-$sdkVersion php-sdk } end { }