Files
grpc/test/cpp/microbenchmarks/callback_test_service.cc
Jordan Rupprecht 41780cddd1 Avoid multimap::find unspecified behavior (#41279)
When a `std::multimap` has multiple entries with the same key, calling `m.find(key)` returns an unspecified element.

Historically, this returns the first matching element. However, this is not guaranteed, and recent libc++ changes make this return an arbitrary element.

Using `m.equal_range(key)` is a replacement that will preserve the current behavior. The behavior of this is guaranteed to return a range of all matching elements in insertion order, and the beginning of the range is the same element as what's normally returned by `m.find(key)`.

Closes #41279

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/41279 from rupprecht:multimap-find 70b116441d03eff80523e010b25336f5a75c70c2
PiperOrigin-RevId: 852844558
2026-01-06 10:44:32 -08:00

114 lines
3.1 KiB
C++

//
//
// Copyright 2019 gRPC authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
//
#include "test/cpp/microbenchmarks/callback_test_service.h"
#include "src/core/util/grpc_check.h"
#include "absl/log/log.h"
namespace grpc {
namespace testing {
namespace {
std::string ToString(const grpc::string_ref& r) {
return std::string(r.data(), r.size());
}
int GetIntValueFromMetadataHelper(
const char* key,
const std::multimap<grpc::string_ref, grpc::string_ref>& metadata,
int default_value) {
if (auto [it, end] = metadata.equal_range(key); it != end) {
std::istringstream iss(ToString(it->second));
iss >> default_value;
}
return default_value;
}
int GetIntValueFromMetadata(
const char* key,
const std::multimap<grpc::string_ref, grpc::string_ref>& metadata,
int default_value) {
return GetIntValueFromMetadataHelper(key, metadata, default_value);
}
} // namespace
ServerUnaryReactor* CallbackStreamingTestService::Echo(
CallbackServerContext* context, const EchoRequest* /*request*/,
EchoResponse* response) {
int response_msgs_size = GetIntValueFromMetadata(
kServerMessageSize, context->client_metadata(), 0);
if (response_msgs_size > 0) {
response->set_message(std::string(response_msgs_size, 'a'));
} else {
response->set_message("");
}
auto* reactor = context->DefaultReactor();
reactor->Finish(grpc::Status::OK);
return reactor;
}
ServerBidiReactor<EchoRequest, EchoResponse>*
CallbackStreamingTestService::BidiStream(CallbackServerContext* context) {
class Reactor : public ServerBidiReactor<EchoRequest, EchoResponse> {
public:
explicit Reactor(CallbackServerContext* context) {
message_size_ = GetIntValueFromMetadata(kServerMessageSize,
context->client_metadata(), 0);
StartRead(&request_);
}
void OnDone() override {
GRPC_CHECK(finished_);
delete this;
}
void OnCancel() override {}
void OnReadDone(bool ok) override {
if (!ok) {
// Stream is over
Finish(grpc::Status::OK);
finished_ = true;
return;
}
if (message_size_ > 0) {
response_.set_message(std::string(message_size_, 'a'));
} else {
response_.set_message("");
}
StartWrite(&response_);
}
void OnWriteDone(bool ok) override {
if (!ok) {
LOG(ERROR) << "Server write failed";
return;
}
StartRead(&request_);
}
private:
EchoRequest request_;
EchoResponse response_;
int message_size_;
bool finished_{false};
};
return new Reactor(context);
}
} // namespace testing
} // namespace grpc