Commit Graph

35 Commits

Author SHA1 Message Date
Nicolas Noble 9877189e45 Merge pull request #11310 from nicolasnoble/import
Import mutations.
2017-07-13 13:39:58 -07:00
Vijay Pai 5e3699493d Merge pull request #11572 from vjpai/internalize
Separate internal-only and public parts of C++ API
2017-07-10 23:22:19 -07:00
David Garcia Quintas 6636b5036e Fix codegen_test_full 2017-07-10 14:41:34 -07:00
Vijay Pai c0baec60a1 Internalize structs and methods meant for being exposed through codegen
or that interface with core and are only for internal use
2017-07-10 14:33:53 -07:00
Nicolas "Pixel" Noble 5d80dc4985 Merge branch 'master' of https://github.com/grpc/grpc into import 2017-06-26 22:01:11 +02:00
Jan Tattermusch 4d5c3102a1 fix remaining license notices 2017-06-08 11:22:41 +02:00
Jan Tattermusch 7897ae9308 auto-fix most of licenses 2017-06-08 11:22:41 +02:00
Nicolas "Pixel" Noble af6c83f9e1 Adding dummy layering check option. 2017-05-19 01:53:56 +02:00
Nicolas "Pixel" Noble eb36b8ac77 Merge branch 'master' of https://github.com/grpc/grpc into import 2017-05-11 23:24:37 +02:00
James Eady 3b26451025 Add static method to generated code to return fully qualified protobuf service name. 2017-05-02 10:45:34 -04:00
Mahak Mukhi ea07b60401 Post-review update 2017-04-18 17:05:49 -07:00
Mahak Mukhi a68829023c more sanity
trying to fix some sanity

nope that didn't work

fixing test failiures

added debug code

more trail and error

more trial and error

cleaning debug code
2017-04-15 19:09:45 -07:00
Mahak Mukhi 443a75dd22 1. Added golden file test.
2. Added support for mock.
3. Sanity fix.
2017-04-14 15:33:55 -07:00
Nicolas "Pixel" Noble 7c26eed838 Buildifier and wrapping test/cpp/* rules with our build system. 2017-04-13 02:03:22 +02:00
Yang Gao d62742193a Merge pull request #8407 from jronak/fixtag
replaced protobuf tag
2017-03-04 20:13:16 -08:00
David Garcia Quintas e854357117 Reintroduced golden_file_test 2017-02-21 10:44:02 -08:00
David Garcia Quintas 1f980cf7bb Removed useless cpp/codegen/golden_file_test 2017-02-17 16:43:26 -08:00
David Garcia Quintas eb4c47e006 test/cpp/codegen 2017-02-17 15:41:20 -08:00
Harvey Tuch 5f3cfe960f Fix read from uninitialized memory bug in GrpcBufferWriter.
This commit fixes an issue in which the following sequence of operations
leads to use of uninitialized memory:

1. Caller invokes GrpcBufferWriter::Next(), and then makes use of 8191
   bytes in the returned buffer (which is 8192 bytes in size).

2. Caller then returns the unused single byte via
   GrpcBufferWriter::BackUp(). This method invokes
   g_core_codegen_interface->grpc_slice_split_tail(), which causes
   backup_slice_ to be a grpc_slice with one byte.

3. At the next invocation of GrpcBufferWriter::Next(), a reference to
   the single byte grpc_slice is returned to the caller.

The problem here is that the returned reference is to the inlined buffer
in the grpc_slice, which is resident in slice_, not the location of the
buffer inside slice_buffer_ after
g_core_codegen_interface->grpc_slice_buffer_add() in
GrpcBufferWriter::Next(). As a result, any data the caller writes to the
returned void* data is lost.

The solution is to avoid inlined backup slices.
2017-02-07 15:45:44 -05:00
Ronak Jain a3f8097b34 replaced protobuf tag in compile_test_golden 2016-12-14 22:52:38 +05:30
Vijay Pai c0b2acb1a0 Use C++11 final and override 2016-11-01 16:31:56 -07:00
Vijay Pai 08126092e6 golden file 2016-10-13 14:17:41 -07:00
David Garcia Quintas d10f1775eb Merge branch 'master' of github.com:grpc/grpc into codegen_cleanse 2016-09-03 12:42:02 +02:00
Vijay Pai 3703ece81b a golden file 2016-08-30 12:13:39 -07:00
Vijay Pai d05cad245a Fix golden test 2016-08-30 10:22:06 -07:00
Vijay Pai 48c9ca2bf1 Update golden file 2016-08-29 17:10:18 -07:00
Vijay Pai 6d214bcff7 Add FCService to golden test 2016-08-04 12:03:12 -07:00
David Garcia Quintas 1399e466b0 removed codegen/time.h 2016-07-27 20:31:55 -07:00
vjpai 9959f3d0ec Fix the golden file - why do we even have this lever? 2016-06-23 23:19:15 -07:00
yang-g 2e08941a37 Use the comments before syntax line as file comments. 2016-04-15 10:46:41 -07:00
yang-g 8282b755a2 Clarify the comments 2016-04-14 17:13:24 -07:00
yang-g b8aa58b2cd Add a test 2016-04-14 15:53:45 -07:00
David Garcia Quintas 3a43cc06a8 Added codegen_test_full
Which makes sure target that depend on both codegen and grpc build.
2016-04-08 16:59:51 -07:00
David Garcia Quintas b942640497 clang-format 2016-03-08 16:25:11 -08:00
David Garcia Quintas 4ac52fa6dd WIP. Added codegen_test 2016-03-06 20:31:39 -08:00