Commit Graph

82 Commits

Author SHA1 Message Date
Craig Tiller 339906443b [clang-format] Match include file ordering to internal clang-format (#40905)
gRPC is currently getting formatted with two different clang-format implementations, and due to some weirdness they have different include file orderings. This change introduces clang-format configuration to ensure that the two systems align - it's *highly* expected that this will need some maintenance going forward as the two systems evolve.

Closes #40905

PiperOrigin-RevId: 819606209
2025-10-15 00:24:11 -07:00
Craig Tiller dbb5164ac7 [clang-format] Remove custom clang-format rules for include ordering (#37820)
Closes #37820

PiperOrigin-RevId: 682352913
2024-10-04 09:44:20 -07:00
Esun Kim a47d91c7b2 [Clean-up] Tidy fix (#37104)
Applied two clang 17 tidy fixes;

- https://clang.llvm.org/extra/clang-tidy/checks/readability/container-size-empty.html
- https://clang.llvm.org/extra/clang-tidy/checks/modernize/make-shared.html

Closes #37104

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37104 from veblush:fix-tidy 7b905869b819ac3bd6c45feed665e1f98a0585ca
PiperOrigin-RevId: 650815403
2024-07-09 18:08:10 -07:00
Alisha Nanda f7962578c1 [gRPC CLI] Add a --channel_args string flag (a=b,c=d).
PiperOrigin-RevId: 625783208
2024-04-17 13:14:34 -07:00
Craig Tiller b0cf42d86e [clang-format] Remove requirement that port_platform.h is at the top (#36281)
Closes #36281

PiperOrigin-RevId: 623176865
2024-04-09 08:58:34 -07:00
Yijie Ma f99b8b5bc4 Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Esun Kim f3fedae7c8 Added readability-redundant-string-cstr (#31707)
* Added readability-redundant-string-cstr

* Auto fix

* No need to wrap std::string
2022-11-18 17:12:46 -08:00
Micah Paul Ramos 1f0c6a6748 fix gprc_cli segfault when using binary in and out (#31411) 2022-10-21 12:05:33 -07:00
Craig Tiller 9c98d67d7a [c++14] absl::make_unique --> std::make_unique (#31159)
* [c++14] absl::make_unique --> std::make_unique

* fix

* fix
2022-09-29 06:45:17 -07:00
Yousuk Seung 747d016397 Support --max_recv_msg_size in grpc cli (#31106)
* Support --max_recv_msg_size in grpc cli

* Comment typos fixed in tests.
2022-09-23 11:13:29 -07:00
Carlos Sobrinho 63df245532 If -infile is not readable, bail out and show an error! (#30760)
Without this, `grpc_cli` will connect, send the metadata and then completely stall until it is killed leading to believe it is the server that is stalled instead of `grpc_cli` that won't send the message.
2022-09-13 12:55:42 -07:00
AJ Heller 85189b24bb Reintroduce: Avoid fully qualifying namespaces (and add check) (#28917)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
AJ Heller e72a5fe5dd Revert "Avoid fully qualifying namespaces (and add check) (#28901)" (#28916)
This reverts commit fc7314c701.
2022-02-17 17:56:19 -08:00
AJ Heller fc7314c701 Avoid fully qualifying namespaces (and add check) (#28901)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
Craig Tiller ea389c00c2 Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
Yonathan Randolph a985978d82 grpc_cli: allow multiple colon-separated paths in --proto_path (#24187)
Co-authored-by: Yash Tibrewal <yashkt@google.com>
Co-authored-by: AJ Heller <hork@google.com>
2021-03-12 16:52:48 -08:00
Esun Kim ec0b88a5d7 Fix google-readability-casting 2020-11-30 17:27:51 -08:00
capstan 131579d52d Roll forward of commit 7883b51: Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.

This reverts commit da66b7d14e.

NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Parveen Kumar ec08d77474 Specify a large value for max metadata size in grpc_cli client channel.
This is useful in cases where server sends back large stacktrace and
default value of 8192 isn't enough.
2020-10-29 13:36:46 -07:00
Nathan Herring da66b7d14e Revert "Abseil Flags" 2020-10-24 15:19:55 -07:00
capstan 7883b5133d Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.
2020-10-23 19:36:33 +02:00
Esun Kim 6ae8463500 Fix by modernize-make-unique 2020-10-16 13:30:56 -07:00
Esun Kim 6d6648c7e1 Fix clang-tidy errors 2020-10-13 09:51:31 -07:00
Alisha Nanda 91627677fd Added timeout flag to grpc cli. 2020-09-14 17:00:45 +00:00
Alisha Nanda a3ef19c1f0 Revert "Add timeout flag to gRPC cli" 2020-09-09 18:32:27 -07:00
Alisha Nanda 4282e968c4 Re-add in all changes, fix check failures. 2020-09-03 04:01:22 +00:00
Alisha Nanda a4eedc1510 Revert "Merge branch 'master' of https://github.com/ananda1066/grpc"
This reverts commit 35e0e96b09, reversing
changes made to b78bc85185.
2020-09-03 01:57:03 +00:00
Alisha Nanda 88d99b4603 Add timeout flag to gRPC cli
Signed-off-by: Alisha Nanda <alishananda@google.com>
2020-09-01 22:10:35 +00:00
Alexander Polcyn f57879ac56 Flag protect new logs 2020-07-22 21:22:05 -07:00
Alexander Polcyn 4bdbd4caef Log the peer address of grpc_cli CallMethod RPCs to stderr 2020-07-20 18:18:42 -07:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Alexander Polcyn 0a452b9d19 Allow configuring default service configs in grpc_cli 2020-06-02 10:51:29 -07:00
Vijay Pai 53e19e8de2 Remove unused parameter warning (20 of 20) 2019-10-17 08:52:15 -07:00
Andrew Scherkus 4bf0048194 Document --noremotedb flag for grpc_cli.
It's surprising that grpc_cli always attempts to use the reflection
service even when providing local proto files. Document the
existence of a flag that surpresses this behavior.
2019-07-16 13:14:28 -04:00
Karthik Ravi Shankar 5274deb32b Fix the rebase and build 2019-04-23 14:12:48 -07:00
Karthik Ravi Shankar e57182ab61 Fix the compile errors for tests and namespace. 2019-04-23 14:00:56 -07:00
xtao 7766912dda fix more detected mu/cv leaks 2019-02-16 00:00:50 +08:00
Yang Gao 6bfb966271 Revert "Revert "grpc_cli json support"" 2018-10-16 15:49:46 -07:00
David G. Quintas a464b4ce39 Revert "grpc_cli json support" 2018-10-16 14:42:37 -07:00
Feso 00bb2a035e Reformatted code as per clang-format 2018-10-16 00:14:09 +01:00
Feso 29c131f790 Refactored based on code review 2018-10-13 19:17:26 +01:00
Feso 44cecbb2f7 grpc_cli json support 2018-10-03 00:50:57 +01:00
Nathan Herring c7fae8812f clang tidy 2018-07-19 23:45:46 +02:00
Nathan Herring 3ed81c8d65 Introduce --ssl_target flag to grpc_cli.
This allows the client to specify the host name of the remote server for the purposes of TLS certificate validation, useful for test certificates and machines with ephemeral IP
addresses with no associated DNS entries that have been assigned TLS certificates.
2018-07-19 18:30:27 +02:00
Yang Gao 045e4f9889 Merge pull request #13796 from y-zeng/cli_token
Report more error messages in grpc_cli
2018-06-08 11:41:01 -07:00
Vijay Pai c90a85649b Change grpc++ references in names to grpcpp 2018-03-08 22:04:59 -08:00
Carlos Valera efce74b525 Print trailing metadata in the "grpc_cli call" command.
This often includes important debugging information when the RPC returns
a non-OK status.
2018-02-21 16:03:00 -08:00
Yuchen Zeng 33aaffa639 clang_format 2017-12-15 11:03:50 -08:00
Yuchen Zeng 6ac62118b7 Report more error messages in grpc_cli 2017-12-14 19:12:42 -08:00
Yuchen Zeng 19889d79e4 Add escape sequences for the grpc_cli metadata flag 2017-12-11 20:58:12 -08:00