44 Commits

Author SHA1 Message Date
Craig Tiller
339906443b [clang-format] Match include file ordering to internal clang-format (#40905)
gRPC is currently getting formatted with two different clang-format implementations, and due to some weirdness they have different include file orderings. This change introduces clang-format configuration to ensure that the two systems align - it's *highly* expected that this will need some maintenance going forward as the two systems evolve.

Closes #40905

PiperOrigin-RevId: 819606209
2025-10-15 00:24:11 -07:00
Craig Tiller
66a137f1d7 [sanity] Restore it (#38869)
Closes #38869

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/38869 from ctiller:nubbins 972d734cdf45a4786de53c51b2ce8cf97a3d38ff
PiperOrigin-RevId: 731570368
2025-02-26 21:26:56 -08:00
Craig Tiller
07188632f4 Tiny formatting cleanups for portability
PiperOrigin-RevId: 731512282
2025-02-26 17:22:27 -08:00
Craig Tiller
dbb5164ac7 [clang-format] Remove custom clang-format rules for include ordering (#37820)
Closes #37820

PiperOrigin-RevId: 682352913
2024-10-04 09:44:20 -07:00
Mark D. Roth
0944410d6c [reorg] move test/core/util -> test/core/test_util (#36446)
Closes #36446

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36446 from markdroth:reorg_test 5dcc85e006581a8fc52a3a914baa5f33e4a21589
PiperOrigin-RevId: 629229220
2024-04-29 17:06:40 -07:00
Yijie Ma
f99b8b5bc4 Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Craig Tiller
9c98d67d7a [c++14] absl::make_unique --> std::make_unique (#31159)
* [c++14] absl::make_unique --> std::make_unique

* fix

* fix
2022-09-29 06:45:17 -07:00
AJ Heller
18a8f6aad9 Refactor end2end tests to exercise each EventEngine (#29202)
* Refactor end2end tests to exercise each EventEngine

* fix incorrect bazel_only exclusions

* Automated change: Fix sanity tests

* microbenchmark fix

* sanitize, fix iOS flub

* Automated change: Fix sanity tests

* iOS fix

* reviewer feedback

* first pass at excluding EventEngine test expansion

Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.

* end2end fuzzers to be fuzzed differently via EventEngine.

* sanitize

* reviewer feedback

* remove misleading comment

* reviewer feedback: comments

* EE test_init needs to play with our build system

* fix golden file test runner

Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
AJ Heller
85189b24bb Reintroduce: Avoid fully qualifying namespaces (and add check) (#28917)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
AJ Heller
e72a5fe5dd Revert "Avoid fully qualifying namespaces (and add check) (#28901)" (#28916)
This reverts commit fc7314c701.
2022-02-17 17:56:19 -08:00
AJ Heller
fc7314c701 Avoid fully qualifying namespaces (and add check) (#28901)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
Craig Tiller
ea389c00c2 Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
Mark D. Roth
27e1c1c56d clang-tidy: enable google-readability-braces-around-statements 2020-11-06 13:41:44 -08:00
Esun Kim
6ae8463500 Fix by modernize-make-unique 2020-10-16 13:30:56 -07:00
Esun Kim
8d0e703393 Merge pull request #22813 from mehrdada/fix-static-initialization-crap
Fix channelz plugin initializer
2020-07-06 11:19:05 -07:00
Esun Kim
165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Mehrdad Afshari
d9e3a49fe1 Fix server_builder_plugin_test 2020-04-28 20:18:01 -07:00
Vijay Pai
fbfaffaf5a clang-format 2019-10-17 09:07:46 -07:00
Vijay Pai
30f1230c10 Remove unused parameter warning (16 of 20) 2019-10-17 08:51:55 -07:00
Vijay Pai
5d7e4bb301 Stop using deprecated gtest macros 2019-09-24 14:56:41 -07:00
Karthik Ravi Shankar
603d014f0e Changes to fold credentials into grpc_impl from grpc 2019-04-23 13:54:26 -07:00
yang-g
e75fc243da change tests to use the new class instead of grpc_test_init 2018-11-30 08:57:38 -08:00
Vijay Pai
c90a85649b Change grpc++ references in names to grpcpp 2018-03-08 22:04:59 -08:00
Muxi Yan
6f0b195d20 Replace GRPC_COMPRESS_MESSAGE_* with GRPC_COMPRESS_* 2018-02-06 18:17:42 -08:00
Muxi Yan
8fa4d15513 Fix C++ builds 2017-09-26 09:53:55 -07:00
Jan Tattermusch
7897ae9308 auto-fix most of licenses 2017-06-08 11:22:41 +02:00
Nicolas "Pixel" Noble
3726e3d37b Moving gtest include down.
In some cases, depending on the direction of the wind, and the phase of the moon, gtest can interfere with protobuf badly with macros cross-pollution between the two projects. Moving the gtest inclusion at the end makes the problem go away.
2017-05-10 18:33:12 +02:00
Vijay Pai
320ed13d3e Deprecate grpc::thread and sync in favor of std::thread,mutex,etc 2016-11-01 17:16:55 -07:00
Vijay Pai
713c7b87e1 clang-format 2016-11-01 16:33:18 -07:00
Vijay Pai
c0b2acb1a0 Use C++11 final and override 2016-11-01 16:31:56 -07:00
Nicolas "Pixel" Noble
e053e730d2 Avoid using certain C++11-isms with grpc::thread, as it's not necessarily std::thread. 2016-07-14 00:42:07 +02:00
Craig Tiller
04a468122f Add comment 2016-06-21 09:16:57 -07:00
Craig Tiller
d263b925e8 Make sure to poll cq 2016-06-21 09:15:57 -07:00
vjpai
97da6473b4 Manual clang-format 2016-06-13 09:56:26 -07:00
Vijay Pai
15855f3e7f Switch server builder plugin API to something that will work with gcc4.4 2016-06-10 12:25:32 -07:00
Jan Tattermusch
2ff798629c Merge pull request #6664 from dklempner/server_builder_plugin_test
Fix a missing initialization
2016-06-02 20:28:39 -04:00
Craig Tiller
718ce51af8 Fix server plugin test 2016-05-20 10:44:23 -07:00
Craig Tiller
aae6c2cb96 Fix server plugin test 2016-05-20 08:58:30 -07:00
David Klempner
b941d5a4aa Fix a missing initialization 2016-05-19 21:00:47 -07:00
Yuchen Zeng
7d099a5c90 Fix naming and comment problems 2016-05-06 13:21:36 -07:00
Yuchen Zeng
3b8f3354de Add plugins at the time of static initialization 2016-05-03 12:18:13 -07:00
Yuchen Zeng
c049035bed Add GRPC_ prefix for macros 2016-04-29 14:05:08 -07:00
Yuchen Zeng
018bf1a864 modified has_async_methods and has_sync_methods of TestServerBuilderPlugin 2016-04-29 13:39:17 -07:00
Yuchen Zeng
a42ec21341 Server builder plugin 2016-04-29 13:05:36 -07:00