33 Commits

Author SHA1 Message Date
Nathan Baulch b2a05bebe0 [maintenance] Fix cpp typos (#37755)
Continuation of #37541 but focused on C++.

Closes #37755

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37755 from NathanBaulch:typos-cpp 9a7fd9d65fa97a689d529772534df1a501031e9f
PiperOrigin-RevId: 684600898
2024-10-10 15:37:18 -07:00
Eugene Ostroukhov 440eef2288 [Import] Revert #34027 and #34129 (#34133)
This reverts commit 16b67ae312.
2023-08-22 15:55:59 -07:00
Eugene Ostroukhov cd873f355b Revert "[Windows] Make resolver_component_tests_runner_invoker run wi… (#34129)
…th Bazel on Windows (#34107)"

This reverts commit d540b4c088.
2023-08-22 13:44:15 -07:00
Yijie Ma d540b4c088 [Windows] Make resolver_component_tests_runner_invoker run with Bazel on Windows (#34107)
Local Bazel invocation succeeds:

```
C:\Users\yijiem\projects\grpc>bazel --output_base=C:\bazel2 test --dynamic_mode=off --verbose_failures //test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1
INFO: Analyzed target //test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1 (0 packages loaded, 0 targets configured).
INFO: Found 1 test target...
Target //test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1 up-to-date:
  bazel-bin/test/cpp/naming/resolver_component_tests_runner_invoker@poller=epoll1.exe
INFO: Elapsed time: 199.262s, Critical Path: 193.48s
INFO: 2 processes: 1 internal, 1 local.
INFO: Build completed successfully, 2 total actions
//test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1  PASSED in 193.4s

Executed 1 out of 1 test: 1 test passes.
```

The local invocation of RBE failed with linker error `LINK : error
LNK2001: unresolved external symbol mainCRTStartup`, but that does not
limited to this target:
https://gist.github.com/yijiem/2c6cbd9a31209a6de8fd711afbf2b479.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
2023-08-21 16:20:55 -07:00
Yijie Ma a7bf07e86a [EventEngine] PosixEventEngine DNS Resolver (#32701)
This PR implements a c-ares based DNS resolver for EventEngine with the
reference from the original
[grpc_ares_wrapper.h](../blob/master/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.h).
The PosixEventEngine DNSResolver is implemented on top of that. Tests
which use the client channel resolver API
([resolver.h](../blob/master/src/core/lib/resolver/resolver.h#L54)) are
ported, namely the
[resolver_component_test.cc](../blob/master/test/cpp/naming/resolver_component_test.cc)
and the
[cancel_ares_query_test.cc](../blob/master/test/cpp/naming/cancel_ares_query_test.cc).
The WindowsEventEngine DNSResolver will use the same EventEngine's
grpc_ares_wrapper and will be worked on next.

The
[resolve_address_test.cc](https://github.com/grpc/grpc/blob/master/test/core/iomgr/resolve_address_test.cc)
which uses the iomgr
[DNSResolver](../blob/master/src/core/lib/iomgr/resolve_address.h#L44)
API has been ported to EventEngine's dns_test.cc. That leaves only 2
tests which use iomgr's API, notably the
[dns_resolver_cooldown_test.cc](../blob/master/test/core/client_channel/resolvers/dns_resolver_cooldown_test.cc)
and the
[goaway_server_test.cc](../blob/master/test/core/end2end/goaway_server_test.cc)
which probably need to be restructured to use EventEngine DNSResolver
(for one thing they override the original grpc_ares_wrapper's free
functions). I will try to tackle these in the next step.
<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
2023-07-21 13:24:16 -07:00
Lidi Zheng 2231c2ba77 Introduce Python import sorting to our sanity test suite (#26768)
* Add isort_code.sh to sanity tests

* Run tools/distrib/isort_code.sh

* Fine tune the import order for relative imports

* Make pylint and project generation happy

* Fix a few corner cases

* Use --check instead of --diff

* The import order impacts test result somehow

* Make isort print diff and check output at the same time

* Let tools/run_tests/python_utils be firstparty library

* Run isort against latest HEAD
2021-07-26 12:31:21 -07:00
yang-g c6c3dc57af Remove unneeded filter 2021-01-06 10:59:56 -08:00
Alexander Polcyn 882243606f Add a mechanism to plumb arbitary command line flags to the c-ares unit test binary 2020-12-28 23:22:54 -08:00
Alexander Polcyn aef3bb0157 Remove unnecessary explicit bytes conversion 2020-12-16 10:17:17 -08:00
Alexander Polcyn 408a02379d Make c-ares resolver unit tests runnable under python3 2020-12-15 23:51:19 -08:00
Alexander Polcyn a8d8f9db8c update template 2020-04-01 11:18:51 -07:00
Alexander Polcyn 139d9f6e94 Revert "Revert c-ares as the default resolvre"
This reverts commit ca30b2240f.
2019-01-31 15:06:34 -08:00
Alexander Polcyn ca30b2240f Revert c-ares as the default resolvre 2019-01-25 13:39:45 -08:00
Alexander Polcyn 2b328ee0ca Re-enable c-ares as the default resolver; but keep SRV queries off by default 2019-01-18 17:18:33 -08:00
Alexander Polcyn 371b987bf4 Revert turning c-ares on by default 2019-01-11 10:50:52 -08:00
Alexander Polcyn 46a872864c Turn on c-ares as the default resolver 2019-01-08 14:46:37 -08:00
Alex Polcyn 5cd8b1eb81 Enable c-ares queries on Windows 2018-08-08 15:21:26 -07:00
Alexander Polcyn 50a7213929 Revert "Fix c-ares tests ipv6-only brokenness"
This reverts commit 27718ce64d.
2018-06-11 11:35:32 -07:00
Alexander Polcyn 27718ce64d Fix c-ares tests ipv6-only brokenness 2018-06-06 13:55:13 -07:00
Alexander Polcyn fd1a6604ab Remove a test 2018-05-25 11:53:34 -07:00
Alexander Polcyn 550621c1b5 Make local DNS server tests more generic 2018-05-11 16:24:39 -07:00
Alexander Polcyn 6f8f914f8d cleanup, and get rid of unnecessary timeouts in two places 2018-05-01 20:52:57 -07:00
Alexander Polcyn 29fead7d49 Convert c-ares test runner from bash to python, so that it works on
windows
2018-04-24 16:24:43 -07:00
Alex Polcyn 11a45a8057 Fix c-ares tests under gcc musl 2018-04-05 08:04:28 +00:00
Alexander Polcyn 1eaac47f52 Fix arg parsing in resolver test script 2018-03-13 10:46:59 -07:00
Alexander Polcyn 0a05b782fe Move python DNS utilities to utils subdirectory 2018-03-06 19:22:34 -08:00
Alex Polcyn 3c5e12de08 Remove the C++ test dependency on dig and dnsutils 2018-03-06 11:52:58 -08:00
Mehrdad Afshari 3ce5b53f61 Fix resolver_gce_integration_tests_defs.include to pass shellcheck 2018-02-07 11:43:46 -08:00
Mehrdad Afshari 4c959bab8a Fix resolver_component_tests_defs.include to pass shellcheck 2018-02-07 11:43:23 -08:00
Mehrdad Afshari 11b8878348 Fix private_dns_zone_init_defs.include to pass shellcheck 2018-02-07 11:42:56 -08:00
Mehrdad Afshari df8d8c9192 Fix create_private_dns_zone_defs.include to pass shellcheck 2018-02-07 11:42:30 -08:00
Alexander Polcyn 9e3a76ba71 Add c-ares resolver tests against GCE DNS, using the unit test. 2017-09-27 16:47:56 -07:00
Alexander Polcyn 27bf05d003 Add tests for c-ares wrapper using a local DNS server. 2017-09-14 14:32:30 -07:00