Commit Graph

103 Commits

Author SHA1 Message Date
Tanvi Jagtap
154081a92a [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36678)
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping

1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Reviewers need to check :

1. If the above mapping is correct.
2. The content of the log is as before.
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.

Closes #36678

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36678 from tanvi-jagtap:test_cpp_gpr_log 81b8f4179f6111b902cbed9eb65ef6f41eb1e32d
PiperOrigin-RevId: 636410944
2024-05-22 21:59:06 -07:00
Tanvi Jagtap
de9bdf7f8e [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT (#36269)
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK

Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only a few - which fit into single - line regex will be changed. This would be small in number just to reduce the load later.

Replacing CHECK with CHECK_EQ , CHECK_NE etc could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #36269

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36269 from tanvi-jagtap:tjagtap_gpr_assert_qps 26dcf74e273ed04f4173819d52e96f6c93f64c00
PiperOrigin-RevId: 623504407
2024-04-10 08:41:23 -07:00
Craig Tiller
67f364e23e [cleanup] Eliminate usage of GRPC_ASSERT(false...); (#31757)
* crash function

* progress

* fix

* fix

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fixes

* Automated change: Fix sanity tests

* fix

* Automated change: Fix sanity tests

* fix

* fix

* use cpp attr

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fix

* fix

* fix

* add exclusion

* fix

* typo

* fix

* fmt

* Update tcp_socket_utils.cc

* Automated change: Fix sanity tests

* fix

* revert php changes

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2023-01-11 08:50:32 -08:00
Yijie Ma
f99b8b5bc4 Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Esun Kim
250f9fc026 Revived google-readability-casting (#31607)
* Added google-readability-casting

* Fix

* Use brace init for constants

* more

* Fix

* Fix 2

* More fix

* Fixf
2022-11-11 16:44:37 -08:00
Craig Tiller
004788af3d [cleanup] Remove profiling timers (#30779)
* [cleanup] Remove profiling timers

- nobody has used this system in years
- if we needed it, we'd probably rewrite it at this point to be something more modern
- let's remove it until that need arises

* fix

* fixes
2022-08-30 13:40:08 -07:00
Esun Kim
53ab235fb8 Fix google-explicit-constructor 2020-12-03 15:03:39 -08:00
Esun Kim
e7434d385e Fix by tidy-modernize-use-override 2020-10-16 14:01:06 -07:00
Vijay Pai
37d248abd0 Remove unused parameter warning (19 of 20) 2019-10-17 08:52:10 -07:00
Soheil Hassas Yeganeh
dbf88dd66f Revert "Revert "Introduce string_view and use it for gpr_split_host_port.""
This reverts commit 80c177d4c4.
2019-06-27 20:56:15 -04:00
Soheil Hassas Yeganeh
80c177d4c4 Revert "Introduce string_view and use it for gpr_split_host_port." 2019-06-26 16:22:13 -04:00
Soheil Hassas Yeganeh
ef0f9bf7ec Introduce string_view and use it for gpr_split_host_port. 2019-06-20 23:19:34 -04:00
Noah Eisen
373fc6dc40 Manual fixes to enable performance- clang tidy checks 2018-06-14 14:58:09 -04:00
Noah Eisen
58e0cbf9fb Enable the performance-* clang-tidy checks 2018-06-14 14:58:09 -04:00
kpayson64
7a20c962df Break out qps services into seperate protos 2018-04-18 22:13:09 -07:00
Vijay Pai
c90a85649b Change grpc++ references in names to grpcpp 2018-03-08 22:04:59 -08:00
Vijay Pai
ae376bf9d9 Privatize host_port.h; was not used in any wrapped language implementation 2018-01-25 23:06:24 -08:00
yang-g
ea33017540 Add option to use client side coalescing API in qps test 2018-01-24 09:12:01 -08:00
Vijay Pai
c6587ca11b Reintroduce lambdas 2017-12-04 10:15:19 -08:00
Vijay Pai
f230ffd476 clang-format 2017-12-04 09:58:44 -08:00
Vijay Pai
083b9be1a2 Make all-streams op about cleanup only and replace a lambda with a virtual 2017-12-04 09:56:28 -08:00
Vijay Pai
c8dd4c5139 Remove some unneeded and spammy logs 2017-12-04 01:38:00 -08:00
Vijay Pai
6389457ed2 Adjust stream cancellation point and fix races in sync client 2017-12-04 00:57:58 -08:00
Ken Payson
42bd87e376 Adds gRPC Experimental CQ DoThenAsyncNext lambda API 2017-10-25 09:13:30 -07:00
Craig Tiller
c18ad11837 Wait until all clients connected before starting streams 2017-10-09 13:44:10 -07:00
Nicolas "Pixel" Noble
5d80dc4985 Merge branch 'master' of https://github.com/grpc/grpc into import 2017-06-26 22:01:11 +02:00
Jan Tattermusch
7897ae9308 auto-fix most of licenses 2017-06-08 11:22:41 +02:00
Craig Tiller
840931eec9 More import fixes 2017-05-19 15:37:45 -07:00
Nicolas "Pixel" Noble
eb36b8ac77 Merge branch 'master' of https://github.com/grpc/grpc into import 2017-05-11 23:24:37 +02:00
Nicolas "Pixel" Noble
71ca4200f6 QPS doesn't actually need gtest anymore. 2017-05-10 01:32:31 +02:00
Vijay Pai
eea8cf0fe3 Add QPS tests for one-sided streaming 2017-05-02 09:26:12 -07:00
Craig Tiller
f26caeedc6 clang-format 2017-04-19 06:48:05 -07:00
Craig Tiller
9354720625 Fix infinite streams in qps_test 2017-04-18 19:42:27 +00:00
Vijay Pai
45a9abae95 Add option to limit # of messages per stream with tests 2017-04-03 14:24:53 -07:00
Vijay Pai
24992060c8 Finish streams that error. Don't histogram failed ops.
Fail on failed write
2017-02-28 15:39:22 -08:00
Craig Tiller
7ec4748502 Improve sync streaming benchmark, fix deadlock that can occur sometimes 2017-02-01 16:54:51 -08:00
Vijay Pai
f2764e76f9 clang-format 2016-11-04 07:51:24 -07:00
Vijay Pai
90102c2bfc Eliminate unnecessary uses of new[]/delete[] that can be replaced
with vector

Also start eliminating uses of plain-old delete that are not helpful
2016-11-04 07:51:24 -07:00
Vijay Pai
c0b2acb1a0 Use C++11 final and override 2016-11-01 16:31:56 -07:00
Craig Tiller
86cb138ee9 Handle failed calls in sync client 2016-10-27 15:29:49 -07:00
Craig Tiller
44b12f9e23 clang-format 2016-09-08 10:06:14 -07:00
Craig Tiller
bd37a21c26 Cleanup, debug support 2016-09-07 11:28:56 -07:00
Vijay Pai
f50020ce03 Appease the const gods, improve readability, stop using 0 and 1 as
proxies for false and true.
2016-08-08 07:29:31 -07:00
Vijay Pai
d02988d6b5 clang-format 2016-08-05 09:47:47 -07:00
Vijay Pai
25128f1adf Better ending for open-loop tests: never wait more than 1 second
if we are in termination mode
2016-08-05 09:45:03 -07:00
Vijay Pai
5fde20d9f0 clang-format 2016-07-13 19:25:59 -07:00
Vijay Pai
40317fd720 Resolve pernicious race between destructor and thread functions by insisting that destructor is invoked after the class has gone back to being a harmless single-threaded thing. 2016-07-13 19:20:25 -07:00
Vijay Pai
aa8bbeb6c6 Merge branch 'verbose_errors' into histo 2016-07-08 09:41:59 -07:00
Vijay Pai
f373f2cf8b Stop holding histogram for a long time 2016-07-08 09:40:55 -07:00
vjpai
b0f15e8af3 Reduce assertions, use status codes, increase verbosity on errors 2016-07-06 13:57:01 -07:00