154081a92a
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log ( #36678 )
...
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.
We have the following mapping
1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)
Reviewers need to check :
1. If the above mapping is correct.
2. The content of the log is as before.
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.
Closes #36678
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36678 from tanvi-jagtap:test_cpp_gpr_log 81b8f4179f6111b902cbed9eb65ef6f41eb1e32d
PiperOrigin-RevId: 636410944
2024-05-22 21:59:06 -07:00
de9bdf7f8e
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT ( #36269 )
...
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK
Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only a few - which fit into single - line regex will be changed. This would be small in number just to reduce the load later.
Replacing CHECK with CHECK_EQ , CHECK_NE etc could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36269
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36269 from tanvi-jagtap:tjagtap_gpr_assert_qps 26dcf74e273ed04f4173819d52e96f6c93f64c00
PiperOrigin-RevId: 623504407
2024-04-10 08:41:23 -07:00
67f364e23e
[cleanup] Eliminate usage of GRPC_ASSERT(false...); ( #31757 )
...
* crash function
* progress
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
* fix
* use cpp attr
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* fix
* add exclusion
* fix
* typo
* fix
* fmt
* Update tcp_socket_utils.cc
* Automated change: Fix sanity tests
* fix
* revert php changes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com >
2023-01-11 08:50:32 -08:00
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2022-12-22 23:01:53 -08:00
9c98d67d7a
[c++14] absl::make_unique --> std::make_unique ( #31159 )
...
* [c++14] absl::make_unique --> std::make_unique
* fix
* fix
2022-09-29 06:45:17 -07:00
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
4ba3fa52b9
Clean up some instances of -Wunreachable-code-aggressive ( #27054 )
...
See https://github.com/grpc/grpc/pull/26951 for why this is not enforced
at the moment.
2021-08-18 11:43:46 -07:00
377fe6095a
Upgrade clang-tidy and clang-format to 11 ( #25590 )
...
* Upgrade clang-tidy and clang-format to 11
* Reformat code
* Fix abseil-string-find-str-contains
* Fix modernize-make-unique
2021-03-04 11:54:30 -08:00
ac080fd17a
Fix readability-inconsistent-declaration-parameter-name manually
2020-11-30 14:22:40 -08:00
84df61b31a
Merge pull request #24453 from veblush/tidy-modernize-make-unique
...
[Clang-Tidy] Enable modernize-make-unique
2020-10-16 16:35:08 -07:00
e7434d385e
Fix by tidy-modernize-use-override
2020-10-16 14:01:06 -07:00
6ae8463500
Fix by modernize-make-unique
2020-10-16 13:30:56 -07:00
165ee5007a
Replaced grpc::string with std::string
2020-06-29 17:56:36 -07:00
415d41f9e8
Rerun clang-formatter-7
2020-03-03 10:46:55 -08:00
ece1ed7906
clang-format
2019-10-17 09:08:38 -07:00
37d248abd0
Remove unused parameter warning (19 of 20)
2019-10-17 08:52:10 -07:00
e8bece9c71
some typo errors too.
2019-06-05 09:33:38 +08:00
373fc6dc40
Manual fixes to enable performance- clang tidy checks
2018-06-14 14:58:09 -04:00
58e0cbf9fb
Enable the performance-* clang-tidy checks
2018-06-14 14:58:09 -04:00
7a20c962df
Break out qps services into seperate protos
2018-04-18 22:13:09 -07:00
c90a85649b
Change grpc++ references in names to grpcpp
2018-03-08 22:04:59 -08:00
7fed69b7ad
Use static_cast rather than reinterpret_cast whenever possible
2018-03-05 16:35:10 -08:00
ea33017540
Add option to use client side coalescing API in qps test
2018-01-24 09:12:01 -08:00
8873975a30
Fix Async QPS Test
2017-12-07 10:24:25 -08:00
7cf8d72c25
Fix TSAN json_run_localhost flake
2017-11-16 18:36:38 -08:00
baa14a975e
Update clang-format to 5.0
2017-11-03 09:09:36 -07:00
918ce7a686
Fix QPS Async Client Next loop
2017-10-27 02:48:15 -07:00
42bd87e376
Adds gRPC Experimental CQ DoThenAsyncNext lambda API
2017-10-25 09:13:30 -07:00
c18ad11837
Wait until all clients connected before starting streams
2017-10-09 13:44:10 -07:00
43b55221e4
Cancel outstanding streams when shutting down the client
2017-09-19 11:45:56 -07:00
4b047a3bff
Construction of streams shouldn't require triggering async ops
2017-09-14 17:55:13 -07:00
58c33ba19b
Decouple alarm construction from setting to avoid races in MT code
2017-09-07 11:34:13 -07:00
c38955501b
Move some internal includes to the right places
2017-08-24 10:16:40 -07:00
af313caab8
Eliminate copy in QPS Driver
2017-08-02 16:05:48 -07:00
c8e7a52fc7
Merge remote-tracking branch 'origin/master' into HEAD
2017-06-13 02:52:13 +00:00
7897ae9308
auto-fix most of licenses
2017-06-08 11:22:41 +02:00
4b07aab513
Support multiple threads per cq sharing, add tests
2017-05-23 09:20:56 -07:00
6ca796d7ad
merge master, resolve conflict
2017-05-15 14:15:34 -07:00
57e12b1786
Merge branch 'poll_stat' of github.com:lyuxuan/grpc into poll_stat
2017-05-08 11:36:07 -07:00
a7f7fcf94a
Merge branch 'master' into poll_stat
2017-05-08 11:35:00 -07:00
85d3a53905
change gpr_atm to int
2017-05-08 06:24:34 +00:00
d868a07d7c
Merge github.com:grpc/grpc into uberpoll
2017-05-07 20:02:30 -07:00
87827e03aa
use lock instand of atomics, fix include position
2017-05-05 14:12:42 -07:00
bfb495d026
add override to GetPollCount() function
2017-05-05 10:57:35 -07:00
f8365cd87b
clean up, fix minor issue
2017-05-03 23:29:17 -07:00
28efff3e1e
clang-format
2017-05-03 22:50:56 -07:00
999ac157e6
initial implementation.
2017-05-03 21:36:36 -07:00
c3571791a5
Isolate timer checking in its own thread
2017-05-02 14:36:33 -07:00
eea8cf0fe3
Add QPS tests for one-sided streaming
2017-05-02 09:26:12 -07:00
45a9abae95
Add option to limit # of messages per stream with tests
2017-04-03 14:24:53 -07:00
Tanvi Jagtap