Yijie Ma
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Cheng-Yu Chung
d699b574a8
Remove include/grpcpp/impl/codegen/server_callback.h ( #31279 )
2022-10-12 15:37:14 -04:00
AJ Heller
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
AJ Heller
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
2022-02-17 17:56:19 -08:00
AJ Heller
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
Craig Tiller
28316341bf
Annotate impl/codegen with IWYU pragmas ( #27252 )
...
* Add a tool to annotate impl/codegen with IWYU pragmas
* xx
* oops
* fmt
* x
* fix wrong direction bug
* use defaultdict
* better annotations
* better annotations
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com >
2021-09-08 09:13:03 -07:00
Vijay Pai
3e19babc1e
Remove all possible traces of grpc::experimental for callback API ( #26584 )
2021-06-30 19:55:08 -07:00
Vijay Pai
cf1ebf7387
Remove experimental tag from uses of the C++ callback API ( #26495 )
2021-06-20 00:47:07 -07:00
Vijay Pai
dae5624e47
Thread annotations for C++ callback API headers ( #25571 )
...
* Annotate headers
* clang-format
2021-03-04 10:15:21 -08:00
Vijay Pai
909cac3866
Document reaction concurrency and reactor lifetime ( #25481 )
2021-02-24 09:18:15 -08:00
Esun Kim
decc199ca8
Fix by clang-tidy
2020-12-03 16:24:19 -08:00
Vijay Pai
b427807f3b
Fix server backlog processing to not set stream until backlog cleared
2020-09-17 15:38:06 -07:00
Karthik Ravi Shankar
375d92be8d
Merge branch 'master' into sync-stream
2020-09-08 15:14:48 -07:00
Karthik Ravi Shankar
67667eb7b6
Revert ...
2020-09-03 08:16:10 -07:00
Vijay Pai
62e01dd922
Add non-experimental:: versions under ifdef
2019-12-04 06:27:41 -08:00
Vijay Pai
94a8c5888a
Remove namespace experimental from namespace grpc_impl
2019-12-02 15:36:05 -08:00
Vijay Pai
be6979202b
Revamp server-side C++ callback API, message allocator, and mocking
2019-11-20 16:56:18 -08:00
Moiz Haidry
bf994e48d9
Move grpc async, callback and sync implementation to grpc_impl namespace
2019-07-01 14:05:54 -07:00
Yang Gao
ea63190498
Merge pull request #19371 from yang-g/virtual_me
...
Add comments and rename internal methods
2019-06-19 12:25:05 -07:00
yang-g
7b0ee41fd5
Resolve comment
2019-06-19 10:28:35 -07:00
yang-g
7db36fe0a0
Add comments and rename internal methods
2019-06-17 11:18:03 -07:00
Soheil Hassas Yeganeh
85f08100d4
Avoid using seq_cst atomic operations in grpcpp when unnecessary.
...
These cases are almost all in the callback API.
Also use atomic<intptr_t> insteda of atomic_int for consistency with
gpr_atm and grpc_core::Atomic.
2019-06-16 16:09:24 -04:00
yang-g
b216c34314
Mark some methods virtual
2019-06-13 22:15:53 -07:00
Moiz Haidry
226e63dd0c
Move server context implementation to grpc_impl namespace and typedef the ref to it
2019-06-05 10:41:30 -07:00
yang-g
7c5bfbbb32
Resolve comments
2019-05-16 09:19:44 -07:00
yang-g
51210ba922
Update the message allocator API
2019-05-16 09:19:44 -07:00
Yang Gao
5170c613cc
Merge pull request #18784 from yang-g/message_allocator
...
Message allocator support for callback unary
2019-04-23 15:49:49 -07:00
yang-g
41824319fa
Resolve review comments
2019-04-23 08:54:36 -07:00
Vijay Pai
1a4f5e8ade
Fix typo in comment
...
It's a ServerWriteReactor
2019-04-22 11:29:16 -07:00
yang-g
051d421579
Resolve sanity
2019-04-17 08:57:48 -07:00
yang-g
6929cdd654
initial
2019-04-16 15:43:58 -07:00
Vijay Pai
41c6cba9f5
Make sure that OnCancel happens after OnStarted
2019-04-10 11:32:34 -07:00
Hope Casey-Allen
b86e70592e
Format
2019-04-08 10:13:17 -07:00
Hope Casey-Allen
cee3292cdf
Update callback API documentation
2019-04-08 09:11:04 -07:00
Vijay Pai
847b0155d9
Promise to call OnStarted and forbid Start* until after OnStarted
2019-03-27 16:30:07 -07:00
Vijay Pai
abb991be25
Further clarify some APIs by removing their comments from internal::
2019-03-27 09:46:08 -07:00
Vijay Pai
9169159f30
Comments for all callback API methods
2019-03-26 23:33:23 -07:00
Vijay Pai
7b3a120295
Address reviewer comments
2019-03-18 16:51:15 -07:00
Vijay Pai
93f0a3f653
Address reviewer comments
2019-03-18 15:37:35 -07:00
Vijay Pai
04a6b8467c
Support callback on cancellation of server-side unary RPCs
2019-03-18 12:00:57 -07:00
Yuwei Huang
3cbf4f50ea
Remove extra semicolons after function definitions
...
We are planning to enable -Wextra-semi flag in our project but some
header files in gRPC have extra semicolons that violates the check and
blocks us from enabling the flag.
This change removes unnecessary semicolons in the code. Note that having
semicolon after the GRPC_ABSTRACT macro technically also violates the
check, but it's fine for us since they are not used in public headers,
and it will be confusing to have lines ending only with GRPC_ABSTRACT,
so I keep them as-is.
2019-02-20 17:58:30 -08:00
Yash Tibrewal
c6261f4b91
Rename new SendMessage types to SendMessagePtr
2019-01-02 14:46:52 -08:00
Yash Tibrewal
4aeba42528
Provide GetOriginalSendMessage for some APIs
2018-12-28 17:27:38 -08:00
Vijay Pai
2a0c0d7ad6
Streaming API for callback servers
2018-11-30 16:14:21 -08:00
Vijay Pai
526d2e6004
Refactoring of CallbackWithSuccessTag
2018-11-06 11:20:50 -08:00
Vijay Pai
932abf48a3
Address reviewer comments.
2018-10-31 01:02:07 -07:00
Vijay Pai
84e763f10a
Experimental C++ server callback unary API
2018-10-29 13:41:25 -07:00
