Commit Graph

73 Commits

Author SHA1 Message Date
Yijie Ma
f99b8b5bc4 Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Cheng-Yu Chung
4ba0f9afb5 Revert "Revert "Remove include/grpcpp/impl/codegen/client_callback.h (#31005)" (#31079)" (#31087)
This reverts commit da08fe1d6f.
2022-10-04 13:59:32 -04:00
Craig Tiller
da08fe1d6f Revert "Remove include/grpcpp/impl/codegen/client_callback.h (#31005)" (#31079)
This reverts commit 17f515744f.
2022-09-20 18:58:54 -07:00
Cheng-Yu Chung
17f515744f Remove include/grpcpp/impl/codegen/client_callback.h (#31005) 2022-09-20 13:51:55 -04:00
AJ Heller
85189b24bb Reintroduce: Avoid fully qualifying namespaces (and add check) (#28917)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
AJ Heller
e72a5fe5dd Revert "Avoid fully qualifying namespaces (and add check) (#28901)" (#28916)
This reverts commit fc7314c701.
2022-02-17 17:56:19 -08:00
AJ Heller
fc7314c701 Avoid fully qualifying namespaces (and add check) (#28901)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
Craig Tiller
28316341bf Annotate impl/codegen with IWYU pragmas (#27252)
* Add a tool to annotate impl/codegen with IWYU pragmas

* xx

* oops

* fmt

* x

* fix wrong direction bug

* use defaultdict

* better annotations

* better annotations

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-09-08 09:13:03 -07:00
Vijay Pai
3e19babc1e Remove all possible traces of grpc::experimental for callback API (#26584) 2021-06-30 19:55:08 -07:00
Vijay Pai
153bc67f45 Revert "Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)" (#26375)" (#26379)
This reverts commit 259a74c0e6.
2021-05-27 09:16:05 -07:00
Yash Tibrewal
259a74c0e6 Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)" (#26375)
This reverts commit 66253c521a.
2021-05-26 22:20:23 -07:00
Vijay Pai
66253c521a Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)
* Revert "Revert "Expose trailers-only response status through C++ callback API (#26249)" (#26363)"

This reverts commit 05c3b30ea0.

* Move the trailers_only check from ClientContext to ClientReactor

* Remove unneeded change in client_context.cc
2021-05-25 17:43:21 -07:00
Yash Tibrewal
05c3b30ea0 Revert "Expose trailers-only response status through C++ callback API (#26249)" (#26363)
This reverts commit 393bae7e88.
2021-05-25 13:44:10 -07:00
Vijay Pai
393bae7e88 Expose trailers-only response status through C++ callback API (#26249)
* Expose trailers-only response status through callback API

* Fix change-detector test

* Address reviewer comment about trailers_only headers

* Add TODO requested by markdroth

* Move variable in struct to improve space efficiency

* Don't instantiate ExecCtx in channel_args destructor unless needed
2021-05-21 14:42:41 -07:00
Vijay Pai
dae5624e47 Thread annotations for C++ callback API headers (#25571)
* Annotate headers

* clang-format
2021-03-04 10:15:21 -08:00
Vijay Pai
26e4c14b1e Add virtual destructor to ClientReactor base class (#25599)
* Add virtual destructor

* Remove subclass empty destructors
2021-03-02 21:08:07 -08:00
Vijay Pai
909cac3866 Document reaction concurrency and reactor lifetime (#25481) 2021-02-24 09:18:15 -08:00
Esun Kim
decc199ca8 Fix by clang-tidy 2020-12-03 16:24:19 -08:00
Vijay Pai
476743786b Also reduce templating for ClientUnaryReactor 2020-10-20 04:12:40 -07:00
Vijay Pai
8f9233ca30 Merge pull request #24423 from vjpai/callback_client_code_size_v2
Reduce templating for unary callback client RPC without protobuf dependence
2020-10-20 00:07:51 -07:00
Esun Kim
34789b2d83 Fix by clang-format-8. 2020-10-16 11:37:18 -07:00
Vijay Pai
7e72bba162 Reduce templating for unary callback client RPC 2020-10-15 04:47:39 -07:00
Karthik Ravi Shankar
375d92be8d Merge branch 'master' into sync-stream 2020-09-08 15:14:48 -07:00
Karthik Ravi Shankar
67667eb7b6 Revert ... 2020-09-03 08:16:10 -07:00
Vijay Pai
62e01dd922 Add non-experimental:: versions under ifdef 2019-12-04 06:27:41 -08:00
Vijay Pai
94a8c5888a Remove namespace experimental from namespace grpc_impl 2019-12-02 15:36:05 -08:00
Moiz Haidry
d8c0182360 Expose some of the internal codegen interfaces 2019-07-02 12:32:14 -07:00
Moiz Haidry
bf994e48d9 Move grpc async, callback and sync implementation to grpc_impl namespace 2019-07-01 14:05:54 -07:00
Moiz Haidry
3ce20819cf Modify codegen to use grpc_impl namespace and other cleanups 2019-06-21 10:51:57 -07:00
Soheil Hassas Yeganeh
85f08100d4 Avoid using seq_cst atomic operations in grpcpp when unnecessary.
These cases are almost all in the callback API.

Also use atomic<intptr_t> insteda of atomic_int for consistency with
gpr_atm and grpc_core::Atomic.
2019-06-16 16:09:24 -04:00
Karthik Ravi Shankar
7e18e6cf3f Fix clang errors. 2019-06-05 16:47:29 -07:00
Karthik Ravi Shankar
522ddfe273 Move ClientContext to grpc_impl
ClientContext is another file which needs to be moved from grpc to
grpc_impl for referencing it.
2019-06-05 16:31:39 -07:00
Karthik Ravi Shankar
03b079499c Move CompletionQueue and Channel 2019-05-17 09:16:32 -07:00
Karthik Ravi Shankar
40210d3b8a Move Channel to grpc_impl 2019-05-17 09:12:33 -07:00
Karthik Ravi Shankar
772a74aced Revert changes to Channel 2019-05-15 14:24:17 -07:00
Karthik Ravi Shankar
6be0b06c69 Revert "Fold CompletionQueue and ServerCompletionQueue into grpc_impl" 2019-05-15 13:38:34 -07:00
Karthik Ravi Shankar
5de22c4bd4 Merge branch 'master' into grpc_namespace_completion_queue 2019-04-30 17:46:33 -07:00
Karthik Ravi Shankar
9eec789a4d Merge branch 'grpc_namespace_channel_new' into grpc_namespace_completion_queue 2019-04-30 15:51:49 -07:00
Karthik Ravi Shankar
e3a0c85960 Merge branch 'master' into grpc_namespace_channel_new 2019-04-30 14:30:03 -07:00
Hope Casey-Allen
3433749d1b Add clarification to callback API documentation 2019-04-24 16:37:19 -07:00
Vijay Pai
20c08dbc7a Add client-side unary reactor model 2019-04-19 16:10:08 -07:00
Karthik Ravi Shankar
62fb156122 Fold CompletionQueue and ServerCompletionQueue into grpc_impl 2019-04-11 13:16:32 -07:00
Karthik Ravi Shankar
973fa6950e Fold Channel into grpc_impl from grpc namespace 2019-04-11 12:04:23 -07:00
Karthik Ravi Shankar
dad3f34207 Revert "Revert "Revert "Folding the Channel class into the grpc_impl namespace.""" 2019-04-10 12:14:04 -07:00
Karthik Ravi Shankar
891b6cf7ae Revert "Folding CompletionQueue and ServerCompletionQueue." 2019-04-10 10:22:59 -07:00
Karthik Ravi Shankar
d2b2f7f5a3 Merge branch 'master' into completion-queue-fold 2019-04-09 13:44:33 -07:00
Karthik Ravi Shankar
afd602ccba Merge branch 'master' into completion-queue-fold 2019-04-09 10:46:03 -07:00
Karthik Ravi Shankar
9875fabdd4 Merge branch 'master' into revert-18076-revert-17797-channel 2019-04-08 12:55:07 -07:00
Vijay Pai
9169159f30 Comments for all callback API methods 2019-03-26 23:33:23 -07:00
Vijay Pai
48ce4ca939 Add support for extra-reaction operations via Holds 2019-03-15 16:17:01 -07:00