doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #6440] Initial PHPStan integration #9983

New Issue
Open
opened 2026-01-22 16:06:03 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:06:03 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/6440

State: closed
Merged: No

This is a starting point to begin using static analysis in Doctrine ORM codebase. PHPStan is already used by doctrine/common and doctrine/annotations so I think it's logical that the ORM repo starts using it too :)

The build will now fail, I wasn't sure what to do about this one error:

 ------ ------------------------------------------------------------------------------------------
  Line   lib/Doctrine/ORM/Query/ResultSetMapping.php
 ------ ------------------------------------------------------------------------------------------
  456    Return typehint of method Doctrine\ORM\Query\ResultSetMapping::getRelation() has invalid
         type Doctrine\ORM\Query\AssociationMapping.
 ------ ------------------------------------------------------------------------------------------

The method has no tests and no usage in the project, so I'm really not sure what it's supposed to return.

After you merge this, I can spread the analysis to tests and also increase the level of the analysis to find more errors.

**Original Pull Request:** https://github.com/doctrine/orm/pull/6440 **State:** closed **Merged:** No --- This is a starting point to begin using static analysis in Doctrine ORM codebase. [PHPStan](https://github.com/phpstan/phpstan) is already used by doctrine/common and doctrine/annotations so I think it's logical that the ORM repo starts using it too :) The build will now fail, I wasn't sure what to do about this one error: ``` ------ ------------------------------------------------------------------------------------------ Line lib/Doctrine/ORM/Query/ResultSetMapping.php ------ ------------------------------------------------------------------------------------------ 456 Return typehint of method Doctrine\ORM\Query\ResultSetMapping::getRelation() has invalid type Doctrine\ORM\Query\AssociationMapping. ------ ------------------------------------------------------------------------------------------ ``` The method has no tests and no usage in the project, so I'm really not sure what it's supposed to return. After you merge this, I can spread the analysis to tests and also increase the level of the analysis to find more errors.
admin added the pull-request label 2026-01-22 16:06:03 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9983
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?