[PR #6374] Add failing test case DDC726 #5238 #9954

New Issue

admin · 2026-01-22T16:05:57+01:00

admin commented

2026-01-22 16:05:57 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/6374

State: closed
Merged: No

In order to fix this, and as I'm not really familiar with the Query AST/Parser code, I have some questions:

Is there already an ASTExpression we can use to match (foo, bar)?
The path for Where being ConditionalExpression => ConditionalTerm => ConditionalFactor => ConditionalPrimary => ConditionalExpression, I think that the fix should be here. Or should it be upper in the chain?

@guilhermeblanco (you were assigned on #5238), did you already look into this? Could you share your thoughts on the subject?

Thanks.

**Original Pull Request:** https://github.com/doctrine/orm/pull/6374 **State:** closed **Merged:** No --- In order to fix this, and as I'm not really familiar with the Query AST/Parser code, I have some questions: - Is there already an ASTExpression we can use to match `(foo, bar)`? - The path for Where being ConditionalExpression => ConditionalTerm => ConditionalFactor => ConditionalPrimary => ConditionalExpression, I think that the fix should be [here](https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query/Parser.php#L2497). Or should it be upper in the chain? @guilhermeblanco (you were assigned on #5238), did you already look into this? Could you share your thoughts on the subject? Thanks.

admin added the pull-request label 2026-01-22 16:05:57 +01:00

admin referenced this issue

2026-01-22 16:12:35 +01:00

[PR #9954] Remove obsolete PHP version checks #12000

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9954