doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #5628] Make ClassMetadataFactory more configurable #9673

New Issue
Closed
opened 2026-01-22 16:05:04 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:05:04 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/5628

State: closed
Merged: No

It looks reasonable to make the ClassMetadataFactory more configurable to avoid such tricks as I've implemented at Atlantic18/DoctrineExtensions#1512 for example.

In the past there was no reason for this changes as well as this tricks. But 8bdb713073 changed things.

Also there are improvements to be made before this code can be merged.

  1. \Exception is to general and non-informative.
  2. I think $metadataClass must be configurable through doctrine.orm.entity_managers like doctrine.orm.entity_managers.default.class_metadata_factory_name

Suggestions and reviews are welcome!

**Original Pull Request:** https://github.com/doctrine/orm/pull/5628 **State:** closed **Merged:** No --- It looks reasonable to make the `ClassMetadataFactory` more configurable to avoid such tricks as I've implemented at Atlantic18/DoctrineExtensions#1512 for example. In the past there was no reason for this changes as well as this tricks. But 8bdb7130738df5b7a9c5d8f73e3cbfb72149c909 changed things. Also there are improvements to be made before this code can be merged. 1. `\Exception` is to general and non-informative. 2. I think `$metadataClass` must be configurable through `doctrine.orm.entity_managers` like `doctrine.orm.entity_managers.default.class_metadata_factory_name` Suggestions and reviews are welcome!
admin added the pull-request label 2026-01-22 16:05:04 +01:00
admin closed this issue 2026-01-22 16:05:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?