doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #1464] [DDC-3609] Syntax error in class table inheritance join when WITH is used in DQL query #1328 #9524

New Issue
Open
opened 2026-01-22 16:04:34 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:04:34 +01:00
Owner
Copy Link

Original Pull Request: https://github.com/doctrine/orm/pull/1464

State: closed
Merged: No

I found that in SqlWalker::walkJoin(), it is using ON if the join type is LEFT or LEFT OUTER. That seems weird, because SqlWalker::walkRangeVariableDeclaration() always adds a JOIN with ON, even in the case of LEFT or LEFT OUTER join. Furthermore, the tests in SelectSqlGenerationTest seem to incorrectly check for the second ON to be present.

However, this change only fixes one of the tests by @adeanzan, the other two are still failing. So I don't know if my fix is correct.

**Original Pull Request:** https://github.com/doctrine/orm/pull/1464 **State:** closed **Merged:** No --- I found that in SqlWalker::walkJoin(), it is using ON if the join type is LEFT or LEFT OUTER. That seems weird, because SqlWalker::walkRangeVariableDeclaration() always adds a JOIN with ON, even in the case of LEFT or LEFT OUTER join. Furthermore, the tests in SelectSqlGenerationTest seem to incorrectly check for the second ON to be present. However, this change only fixes one of the tests by @adeanzan, the other two are still failing. So I don't know if my fix is correct.
admin added the pull-request label 2026-01-22 16:04:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?