[PR #1461] Spl_object_hash conflict on Merge #9520

New Issue

admin · 2026-01-22T16:04:33+01:00

admin commented

2026-01-22 16:04:33 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/1461

State: closed
Merged: No

Hi,

First of all, this is just a proposal and I'm sure there is a better solution for the problem described here. As this is my first hack into doctrine source code I'm not sure consequences that might be cause by my modification (even all unit tests passes).

I have encounter a problem due to spl_object_hash. I have written a functional test in order to reveal my issue.

The problem is when I merge an entity, here $user, UOW keep data on the original entity identified by it's spl_object_hash. Then if I unset this $user the spl_object_hash is now available for new object. So I experimented in my case reuse of previous hash which cause a managed+dirty entity error.

So I see two solutions

UOW keep reference to the entity given as even the given variable is unset there is remaining reference in UOW so the spl_hash will not be released.
Do not store data about the given entity, as merge operation isn't supposed to modified given entity.

I tried to implement the second solution as the first may consume a much more memory.

I don't why the merge operation need to do this, so I encapsulated it to prevent unwanted bug :)

**Original Pull Request:** https://github.com/doctrine/orm/pull/1461 **State:** closed **Merged:** No --- Hi, First of all, this is just a proposal and I'm sure there is a better solution for the problem described here. As this is my first hack into doctrine source code I'm not sure consequences that might be cause by my modification (even all unit tests passes). I have encounter a problem due to spl_object_hash. I have written a functional test in order to reveal my issue. The problem is when I merge an entity, here `$user`, UOW keep data on the original entity identified by it's spl_object_hash. Then if I unset this `$user` the spl_object_hash is now available for new object. So I experimented in my case reuse of previous hash which cause a `managed+dirty entity` error. So I see two solutions - UOW keep reference to the entity given as even the given variable is unset there is remaining reference in UOW so the spl_hash will not be released. - Do not store data about the given entity, as merge operation isn't supposed to modified given entity. I tried to implement the second solution as the first may consume a much more memory. I don't why the merge operation need to do this, so I encapsulated it to prevent unwanted bug :)

admin added the pull-request label 2026-01-22 16:04:33 +01:00

admin closed this issue

2026-01-22 16:04:33 +01:00

admin referenced this issue

2026-01-22 16:11:34 +01:00

[PR #9520] Remove `TreeWalkerChainIterator` #11676

Sign in to join this conversation.