[PR #1164] [QueryBuilder] Remove unused method parameters to run on HHVM/PHP7 #9222

New Issue

admin · 2026-01-22T16:03:37+01:00

admin commented

2026-01-22 16:03:37 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/1164

State: closed
Merged: Yes

PHP5 treats the left part of an assignment to a method parameter as an independent local variable, while HHVM/PHP7 treats it as a reference to the method parameter. This leads to the value of the parameter being changed, which, in turn, causes func_get_args() to return not what is expected.

This commit is a part of the effort to make Symfony run flawlessly on HHVM. This issue causes a bunch of Symfony tests to fail on HHVM.

The master is currently broken, so the best thing I could do was to make sure the number of test failures remained the same after the change.

If possible, please merge this to version 2.2 used by Symfony 2.4.

**Original Pull Request:** https://github.com/doctrine/orm/pull/1164 **State:** closed **Merged:** Yes --- PHP5 treats the left part of an assignment to a method parameter as an independent local variable, while HHVM/PHP7 treats it as a reference to the method parameter. This leads to the value of the parameter being changed, which, in turn, causes func_get_args() to return not what is expected. This commit is a part of the effort to make Symfony run flawlessly on HHVM. This issue causes a bunch of Symfony tests to fail on HHVM. The master is currently broken, so the best thing I could do was to make sure the number of test failures remained the same after the change. If possible, please merge this to version 2.2 used by Symfony 2.4.

admin added the pull-request label 2026-01-22 16:03:37 +01:00

admin closed this issue

2026-01-22 16:03:37 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9222