[PR #1092] [MERGED] [DDC-2794] Arbitrary Join count walkers solution #9145

New Issue

admin · 2026-01-22T16:03:23+01:00

admin commented

2026-01-22 16:03:23 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1092
Author: @birko
Created: 7/30/2014
Status: ✅ Merged
Merged: 9/22/2014
Merged by: @Ocramius

Base: master ← Head: pagination-count-walker

📝 Commits (7)

114bd24 Arbitrary Join count walkers solution
a37f99f Root selection according other pagination tools
1643525 Added Tests for Arbitrary Join
458b953 fixed typos in tests
54ac6a0 Updated Asset queries
d48be34 CS Fixes
589d26f Changed calling $from[0] to using reset($from)

📊 Changes

8 files changed (+117 additions, -50 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/Pagination/CountOutputWalker.php (+2 -1)
📝 lib/Doctrine/ORM/Tools/Pagination/CountWalker.php (+12 -17)
📝 lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php (+2 -1)
📝 lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryWalker.php (+13 -14)
📝 lib/Doctrine/ORM/Tools/Pagination/WhereInWalker.php (+12 -17)
📝 tests/Doctrine/Tests/ORM/Tools/Pagination/CountWalkerTest.php (+16 -0)
📝 tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryWalkerTest.php (+31 -0)
📝 tests/Doctrine/Tests/ORM/Tools/Pagination/WhereInWalkerTest.php (+29 -0)

📄 Description

Possible solution for Arbitrary Join problem in pagination count
walkers:
https://groups.google.com/forum/#!topic/doctrine-user/rpPYCDNKOU8

Added a condition to test query component against SelectStatement from
clause

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1092 **Author:** [@birko](https://github.com/birko) **Created:** 7/30/2014 **Status:** ✅ Merged **Merged:** 9/22/2014 **Merged by:** [@Ocramius](https://github.com/Ocramius) **Base:** `master` ← **Head:** `pagination-count-walker` --- ### 📝 Commits (7) - [`114bd24`](https://github.com/doctrine/orm/commit/114bd2435f301f84b84dd08866bdb8960c523d72) Arbitrary Join count walkers solution - [`a37f99f`](https://github.com/doctrine/orm/commit/a37f99f24205bdcb090e1f4ef1d56df93f6eaa49) Root selection according other pagination tools - [`1643525`](https://github.com/doctrine/orm/commit/164352562bac6e061f33f6696adc4ad2b0fb7062) Added Tests for Arbitrary Join - [`458b953`](https://github.com/doctrine/orm/commit/458b9535221f1b3f2a178ef605c9a631bcdad7fc) fixed typos in tests - [`54ac6a0`](https://github.com/doctrine/orm/commit/54ac6a0535dc9257da44b9824cdfb072292a00b9) Updated Asset queries - [`d48be34`](https://github.com/doctrine/orm/commit/d48be34696176666cd2cc6d841158d790910c638) CS Fixes - [`589d26f`](https://github.com/doctrine/orm/commit/589d26fc5e57a4950d106f5776fdaf066ff2f4ce) Changed calling $from[0] to using reset($from) ### 📊 Changes **8 files changed** (+117 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/Pagination/CountOutputWalker.php` (+2 -1) 📝 `lib/Doctrine/ORM/Tools/Pagination/CountWalker.php` (+12 -17) 📝 `lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php` (+2 -1) 📝 `lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryWalker.php` (+13 -14) 📝 `lib/Doctrine/ORM/Tools/Pagination/WhereInWalker.php` (+12 -17) 📝 `tests/Doctrine/Tests/ORM/Tools/Pagination/CountWalkerTest.php` (+16 -0) 📝 `tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryWalkerTest.php` (+31 -0) 📝 `tests/Doctrine/Tests/ORM/Tools/Pagination/WhereInWalkerTest.php` (+29 -0) </details> ### 📄 Description Possible solution for Arbitrary Join problem in pagination count walkers: https://groups.google.com/forum/#!topic/doctrine-user/rpPYCDNKOU8 Added a condition to test query component against SelectStatement from clause --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:03:23 +01:00

admin referenced this issue

2026-01-22 16:10:39 +01:00

[PR #9145] Draft: Add test showing abstract class must be part of entity hierarchy #11396

admin referenced this issue

2026-01-22 16:13:41 +01:00

[PR #10389] Add runtime validation that the discriminator map contains all entity classes, also abstract ones? #12318

admin referenced this issue

2026-01-22 16:13:45 +01:00

[PR #10411] Fill in missing subclasses when loading ClassMetadata #12339

Sign in to join this conversation.