doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #1072] [CLOSED] Fix attempt of traversing bool in FileLockRegion #9116

New Issue
Closed
opened 2026-01-22 16:03:16 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:03:16 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1072
Author: @kamazee
Created: 6/26/2014
Status: ❌ Closed

Base: master ← Head: fix_glob_call

📝 Commits (1)

  • 98075bc Fix attempt of traversing bool in FileLockRegion

📊 Changes

2 files changed (+11 additions, -4 deletions)

View changed files

📝 lib/Doctrine/ORM/Cache/Region/FileLockRegion.php (+7 -2)
📝 tests/Doctrine/Tests/ORM/Tools/Export/AbstractClassMetadataExporterTest.php (+4 -2)

📄 Description

Minor fix: on some platforms (i.e. ArchLinux) glob() returns false when nothing matched even though no errors occurred. As docs for glob say, such behavior is expected (see ‘Note’ at http://php.net/glob)

This made 1 existing test fail:

./vendor/bin/phpunit 
PHPUnit 4.3-g58f3a0e by Sebastian Bergmann.

Configuration read from /home/alex/git/doctrine2/phpunit.xml.dist

.............................................................   61 / 2495 (  2%)
........S.............E......................................  122 / 2495 (  4%)
.............................................................  183 / 2495 (  7%)
.............................................................  244 / 2495 (  9%)
.............................................................  305 / 2495 ( 12%)
.............................................................  366 / 2495 ( 14%)
.........................S...SSSS.S..........................  427 / 2495 ( 17%)
.............................................................  488 / 2495 ( 19%)
....................................................SS.......  549 / 2495 ( 22%)
.............................................................  610 / 2495 ( 24%)
.............................................................  671 / 2495 ( 26%)
.............................................................  732 / 2495 ( 29%)
.............................................................  793 / 2495 ( 31%)
.......................................................S.SSSS  854 / 2495 ( 34%)
SSSSSSSS.....................................................  915 / 2495 ( 36%)
.........................................SS..................  976 / 2495 ( 39%)
............S...S...........S..............................S. 1037 / 2495 ( 41%)
............................................................. 1098 / 2495 ( 44%)
..................S.......................................... 1159 / 2495 ( 46%)
.................................................SS.......... 1220 / 2495 ( 48%)
.......................S..................................... 1281 / 2495 ( 51%)
............................................................. 1342 / 2495 ( 53%)
............................................................. 1403 / 2495 ( 56%)
............................................................. 1464 / 2495 ( 58%)
............................................................. 1525 / 2495 ( 61%)
............................................................. 1586 / 2495 ( 63%)
.........S.................................................S. 1647 / 2495 ( 66%)
............................................................. 1708 / 2495 ( 68%)
............................................................. 1769 / 2495 ( 70%)
............................................................. 1830 / 2495 ( 73%)
............................................................. 1891 / 2495 ( 75%)
............................................................. 1952 / 2495 ( 78%)
............................................................. 2013 / 2495 ( 80%)
............................................................. 2074 / 2495 ( 83%)
............................................................. 2135 / 2495 ( 85%)
............................................................. 2196 / 2495 ( 88%)
............................................................. 2257 / 2495 ( 90%)
............................................................. 2318 / 2495 ( 92%)
............................................................S 2379 / 2495 ( 95%)
.......S......S.......S.....................S...........S.... 2440 / 2495 ( 97%)
.......................................................

Time: 14.37 seconds, Memory: 164.50Mb

There was 1 error:

1) Doctrine\Tests\ORM\Cache\FileLockRegionTest::testEvictAll
Invalid argument supplied for foreach()

/home/alex/git/doctrine2/lib/Doctrine/ORM/Cache/Region/FileLockRegion.php:204
/home/alex/git/doctrine2/tests/Doctrine/Tests/ORM/Cache/AbstractRegionTest.php:80

Traversing bool is no good and a small check wouldn't hurt there as far as I can tell.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1072 **Author:** [@kamazee](https://github.com/kamazee) **Created:** 6/26/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_glob_call` --- ### 📝 Commits (1) - [`98075bc`](https://github.com/doctrine/orm/commit/98075bc5bcdfd13dbabe0a6e97989c9f2f83b5c2) Fix attempt of traversing bool in FileLockRegion ### 📊 Changes **2 files changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Cache/Region/FileLockRegion.php` (+7 -2) 📝 `tests/Doctrine/Tests/ORM/Tools/Export/AbstractClassMetadataExporterTest.php` (+4 -2) </details> ### 📄 Description Minor fix: on some platforms (i.e. ArchLinux) `glob()` returns `false` when nothing matched even though no errors occurred. As docs for `glob` say, such behavior is expected (see ‘Note’ at http://php.net/glob) This made 1 existing test fail: ``` ./vendor/bin/phpunit PHPUnit 4.3-g58f3a0e by Sebastian Bergmann. Configuration read from /home/alex/git/doctrine2/phpunit.xml.dist ............................................................. 61 / 2495 ( 2%) ........S.............E...................................... 122 / 2495 ( 4%) ............................................................. 183 / 2495 ( 7%) ............................................................. 244 / 2495 ( 9%) ............................................................. 305 / 2495 ( 12%) ............................................................. 366 / 2495 ( 14%) .........................S...SSSS.S.......................... 427 / 2495 ( 17%) ............................................................. 488 / 2495 ( 19%) ....................................................SS....... 549 / 2495 ( 22%) ............................................................. 610 / 2495 ( 24%) ............................................................. 671 / 2495 ( 26%) ............................................................. 732 / 2495 ( 29%) ............................................................. 793 / 2495 ( 31%) .......................................................S.SSSS 854 / 2495 ( 34%) SSSSSSSS..................................................... 915 / 2495 ( 36%) .........................................SS.................. 976 / 2495 ( 39%) ............S...S...........S..............................S. 1037 / 2495 ( 41%) ............................................................. 1098 / 2495 ( 44%) ..................S.......................................... 1159 / 2495 ( 46%) .................................................SS.......... 1220 / 2495 ( 48%) .......................S..................................... 1281 / 2495 ( 51%) ............................................................. 1342 / 2495 ( 53%) ............................................................. 1403 / 2495 ( 56%) ............................................................. 1464 / 2495 ( 58%) ............................................................. 1525 / 2495 ( 61%) ............................................................. 1586 / 2495 ( 63%) .........S.................................................S. 1647 / 2495 ( 66%) ............................................................. 1708 / 2495 ( 68%) ............................................................. 1769 / 2495 ( 70%) ............................................................. 1830 / 2495 ( 73%) ............................................................. 1891 / 2495 ( 75%) ............................................................. 1952 / 2495 ( 78%) ............................................................. 2013 / 2495 ( 80%) ............................................................. 2074 / 2495 ( 83%) ............................................................. 2135 / 2495 ( 85%) ............................................................. 2196 / 2495 ( 88%) ............................................................. 2257 / 2495 ( 90%) ............................................................. 2318 / 2495 ( 92%) ............................................................S 2379 / 2495 ( 95%) .......S......S.......S.....................S...........S.... 2440 / 2495 ( 97%) ....................................................... Time: 14.37 seconds, Memory: 164.50Mb There was 1 error: 1) Doctrine\Tests\ORM\Cache\FileLockRegionTest::testEvictAll Invalid argument supplied for foreach() /home/alex/git/doctrine2/lib/Doctrine/ORM/Cache/Region/FileLockRegion.php:204 /home/alex/git/doctrine2/tests/Doctrine/Tests/ORM/Cache/AbstractRegionTest.php:80 ``` Traversing bool is no good and a small check wouldn't hurt there as far as I can tell. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:03:16 +01:00
admin closed this issue 2026-01-22 16:03:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?