[PR #1063] [MERGED] singularize variable name on add/remove methods for EntityGenerator #9109

New Issue

admin · 2026-01-22T16:03:14+01:00

admin commented

2026-01-22 16:03:14 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1063
Author: @FlorianLB
Created: 6/19/2014
Status: ✅ Merged
Merged: 6/21/2014
Merged by: @guilhermeblanco

Base: master ← Head: master

📝 Commits (1)

fdca5d7 singularize variable name on add/remove methods for EntityGenerator

📊 Changes

2 files changed (+12 additions, -2 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/EntityGenerator.php (+4 -2)
📝 tests/Doctrine/Tests/ORM/Tools/EntityGeneratorTest.php (+8 -0)

📄 Description

Not a big change but corrects an error of plural.

Previously :

    public function addComment(EntityGeneratorComment $comments)
    {
        $this->comments[] = $comments;

        return $this;
    }

With this PR :

    public function addComment(EntityGeneratorComment $comment)
    {
        $this->comments[] = $comment;

        return $this;
    }

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1063 **Author:** [@FlorianLB](https://github.com/FlorianLB) **Created:** 6/19/2014 **Status:** ✅ Merged **Merged:** 6/21/2014 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`fdca5d7`](https://github.com/doctrine/orm/commit/fdca5d7584555771be7e40cbb917c8cfb7841ce6) singularize variable name on add/remove methods for EntityGenerator ### 📊 Changes **2 files changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/EntityGenerator.php` (+4 -2) 📝 `tests/Doctrine/Tests/ORM/Tools/EntityGeneratorTest.php` (+8 -0) </details> ### 📄 Description Not a big change but corrects an error of plural. Previously : ``` php public function addComment(EntityGeneratorComment $comments) { $this->comments[] = $comments; return $this; } ``` With this PR : ``` php public function addComment(EntityGeneratorComment $comment) { $this->comments[] = $comment; return $this; } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:03:14 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9109