doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #1051] [CLOSED] Fixed inconsistent which cause error #9089

New Issue
Open
opened 2026-01-22 16:03:08 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:03:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1051
Author: @66Ton99
Created: 6/6/2014
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/UnitOfWork.php (+1 -1)

📄 Description

If $this->entityChangeSets[$oid] can be empty as we can see from next IF statement but PreUpdateEventArgs constructor accepts only array it will cause error like this

Argument 3 passed to PreUpdateEventArgs::__construct() must be of the type array, null given, called in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php on line 1028 and defined

It fixes http://www.doctrine-project.org/jira/browse/DDC-2726 and #126

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1051 **Author:** [@66Ton99](https://github.com/66Ton99) **Created:** 6/6/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`61e6d28`](https://github.com/doctrine/orm/commit/61e6d28805a33264de933eae542d2ace8a4ddaa7) Fixed inconsistent ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/UnitOfWork.php` (+1 -1) </details> ### 📄 Description If $this->entityChangeSets[$oid] can be empty as we can see from next IF statement but PreUpdateEventArgs constructor accepts only array it will cause error like this ``` Argument 3 passed to PreUpdateEventArgs::__construct() must be of the type array, null given, called in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php on line 1028 and defined ``` It fixes http://www.doctrine-project.org/jira/browse/DDC-2726 and #126 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:03:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9089
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?