mirror of
https://github.com/doctrine/orm.git
synced 2026-03-23 22:42:18 +01:00
[PR #1049] [MERGED] [DDC-3152] Fix redeclaration of methods on entity generation update #9088
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/doctrine/orm/pull/1049
Author: @deeky666
Created: 6/5/2014
Status: ✅ Merged
Merged: 6/6/2014
Merged by: @Ocramius
Base:
master← Head:DDC-3152📝 Commits (1)
dcf8d6aignore case when checking for existing methods to avoid redeclaration on update📊 Changes
2 files changed (+35 additions, -11 deletions)
View changed files
📝
lib/Doctrine/ORM/Tools/EntityGenerator.php(+11 -11)📝
tests/Doctrine/Tests/ORM/Tools/EntityGeneratorTest.php(+24 -0)📄 Description
The
EntityGeneratordoes case-sensitive checks for existing methods on update. This can lead to a PHP fatal error because of illegal method redeclaration if the same methods with another case already exist in the entity class.Method names are now lowercased for comparison to come around this issue.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.