doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #1029] [CLOSED] Override joins #9060

New Issue
Open
opened 2026-01-22 16:03:01 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:03:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1029
Author: @dskora
Created: 5/7/2014
Status: ❌ Closed

Base: master ← Head: dskora/join-override

📝 Commits (1)

  • c6289f6 Override joins scenario + test case

📊 Changes

2 files changed (+20 additions, -0 deletions)

View changed files

📝 lib/Doctrine/ORM/QueryBuilder.php (+9 -0)
📝 tests/Doctrine/Tests/ORM/QueryBuilderTest.php (+11 -0)

📄 Description

It will eliminate error: INNER JOIN': Error: ... is already defined during creating a sql query.

Scenario:
We have a sorting feature on the page which allows users to order by a most reviewed/customer rating, on the same time we might have a filter by an average rating.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1029 **Author:** [@dskora](https://github.com/dskora) **Created:** 5/7/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dskora/join-override` --- ### 📝 Commits (1) - [`c6289f6`](https://github.com/doctrine/orm/commit/c6289f68949a3f92c6f8b93a933977aa159cf35c) Override joins scenario + test case ### 📊 Changes **2 files changed** (+20 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/QueryBuilder.php` (+9 -0) 📝 `tests/Doctrine/Tests/ORM/QueryBuilderTest.php` (+11 -0) </details> ### 📄 Description It will eliminate error: INNER JOIN': Error: ... is already defined during creating a sql query. Scenario: We have a sorting feature on the page which allows users to order by a most reviewed/customer rating, on the same time we might have a filter by an average rating. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:03:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9060
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?