[PR #1024] [CLOSED] [DDC-3107][Persister] Remove the insertSql cache #9052

New Issue

admin · 2026-01-22T16:02:59+01:00

admin commented

2026-01-22 16:02:59 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1024
Author: @tyx
Created: 4/30/2014
Status: ❌ Closed

Base: master ← Head: fix/dont-cache-insert-sql

📝 Commits (1)

e7f4c5d Remove the insertSql cache

📊 Changes

1 file changed (+2 additions, -17 deletions)

View changed files

📝 lib/Doctrine/ORM/Persisters/BasicEntityPersister.php (+2 -17)

📄 Description

Here is a piece of code which leads to an exception if we keep it :
https://gist.github.com/tyx/353de6d6aaf367abd6e6

Sure it is an edge case with tricks but I'm sure Doctrine does not need this kind of optimization.

My 2 cent

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1024 **Author:** [@tyx](https://github.com/tyx) **Created:** 4/30/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/dont-cache-insert-sql` --- ### 📝 Commits (1) - [`e7f4c5d`](https://github.com/doctrine/orm/commit/e7f4c5d567bf57fe343c92f4cae3f25805d96785) Remove the insertSql cache ### 📊 Changes **1 file changed** (+2 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Persisters/BasicEntityPersister.php` (+2 -17) </details> ### 📄 Description Here is a piece of code which leads to an exception if we keep it : https://gist.github.com/tyx/353de6d6aaf367abd6e6 Sure it is an edge case with tricks but I'm sure Doctrine does not need this kind of optimization. My 2 cent --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:02:59 +01:00

admin closed this issue

2026-01-22 16:03:00 +01:00

admin referenced this issue

2026-01-22 16:10:26 +01:00

[PR #9052] chore: merge 2.10.x in 3.0.x #11334

Sign in to join this conversation.