[PR #1019] [CLOSED] Small grammar fix #9041

Closed
opened 2026-01-22 16:02:57 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1019
Author: @flack
Created: 4/28/2014
Status: Closed

Base: masterHead: patch-4


📝 Commits (3)

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 lib/Doctrine/ORM/ORMInvalidArgumentException.php (+2 -2)
📝 lib/Doctrine/ORM/UnitOfWork.php (+3 -3)

📄 Description

The exception was reading

A detached entity was found during {removed|persisted} [entityName] 

I changed the verbs to infinitive now. Alternatively, the text in ORMInvalidArgumentException::detachedEntityCannot could also be changed to read

Detached entity [entityName] cannot be {removed|persisted}  

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1019 **Author:** [@flack](https://github.com/flack) **Created:** 4/28/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-4` --- ### 📝 Commits (3) - [`8ff5251`](https://github.com/doctrine/orm/commit/8ff5251aa6bd8cec01473c8a460e2e9b6173330f) Small grammar fix - [`342a5d7`](https://github.com/doctrine/orm/commit/342a5d707c511820897f587eb3b9e30dbc54b9c1) Improve phrasing on exception message instead of trying to fix callers - [`8ee3b0d`](https://github.com/doctrine/orm/commit/8ee3b0d5fd6e78eee8a4b3478720ed8dafe2b87a) Merge branch 'master' of https://github.com/doctrine/doctrine2 into patch-4 ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/ORMInvalidArgumentException.php` (+2 -2) 📝 `lib/Doctrine/ORM/UnitOfWork.php` (+3 -3) </details> ### 📄 Description The exception was reading ``` A detached entity was found during {removed|persisted} [entityName] ``` I changed the verbs to infinitive now. Alternatively, the text in `ORMInvalidArgumentException::detachedEntityCannot` could also be changed to read ``` Detached entity [entityName] cannot be {removed|persisted} ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:57 +01:00
admin closed this issue 2026-01-22 16:02:58 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9041