[PR #1009] [MERGED] HHVM compatibility #9030

Closed
opened 2026-01-22 16:02:52 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/1009
Author: @Ocramius
Created: 4/10/2014
Status: Merged
Merged: 4/17/2014
Merged by: @FabioBatSilva

Base: masterHead: feature/hhvm-tests


📝 Commits (5)

  • e263426 Removing eager assertion on error suppression when generating schema via tools
  • abb4671 Removing usage of memcache cache in tests (HHVM gets stuck on them on local setups)
  • b4933d7 HHVM tests are not allowed to fail anymore
  • 9ab6ef7 Removing too eager cache tests
  • e125909 Fixed whitespace around imported classes

📊 Changes

3 files changed (+11 additions, -20 deletions)

View changed files

📝 .travis.yml (+0 -2)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2862Test.php (+3 -2)
📝 tests/Doctrine/Tests/ORM/Functional/Ticket/DDC742Test.php (+8 -16)

📄 Description

With this PR (based on DDC-3078, see #1008) we finally get 100% compatibility with HHVM as we described on http://www.doctrine-project.org/2013/12/23/our-hhvm-roadmap.html

This PR needs to be rebased on master once #1008 is merged.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/1009 **Author:** [@Ocramius](https://github.com/Ocramius) **Created:** 4/10/2014 **Status:** ✅ Merged **Merged:** 4/17/2014 **Merged by:** [@FabioBatSilva](https://github.com/FabioBatSilva) **Base:** `master` ← **Head:** `feature/hhvm-tests` --- ### 📝 Commits (5) - [`e263426`](https://github.com/doctrine/orm/commit/e263426cdf3ccb784f17f505d24255064c575f40) Removing eager assertion on error suppression when generating schema via tools - [`abb4671`](https://github.com/doctrine/orm/commit/abb4671bfc7086f079aa00a3c684d41399987a47) Removing usage of memcache cache in tests (HHVM gets stuck on them on local setups) - [`b4933d7`](https://github.com/doctrine/orm/commit/b4933d76c7d865f3b020fa8f3203ec4306ff62bb) HHVM tests are not allowed to fail anymore - [`9ab6ef7`](https://github.com/doctrine/orm/commit/9ab6ef723aba28935f6b45bc4c4d890f9927732b) Removing too eager cache tests - [`e125909`](https://github.com/doctrine/orm/commit/e1259098f55f916c862fe039498be334d9133855) Fixed whitespace around imported classes ### 📊 Changes **3 files changed** (+11 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+0 -2) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2862Test.php` (+3 -2) 📝 `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC742Test.php` (+8 -16) </details> ### 📄 Description With this PR (based on DDC-3078, see #1008) we finally get 100% compatibility with HHVM as we described on http://www.doctrine-project.org/2013/12/23/our-hhvm-roadmap.html This PR needs to be rebased on master once #1008 is merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:52 +01:00
admin closed this issue 2026-01-22 16:02:52 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9030