[PR #993] [CLOSED] Update JoinColumn.php #9011

New Issue

admin · 2026-01-22T16:02:46+01:00

admin commented

2026-01-22 16:02:46 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/993
Author: @KamilKopaczyk
Created: 3/28/2014
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

786678c Update JoinColumn.php

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Mapping/JoinColumn.php (+1 -1)

📄 Description

If $referencedColumnName = 'id' by default, it doesn't make sense to make checks like:

if (empty($joinColumn['referencedColumnName'])) {

(ClassMetaDataInfo file)

Considering you map your column

@ORM\JoinColumn(onDelete="CASCADE")

You'll get JoinColumn with 'id' value, which doesn't let doctrine use naming strategies for referenced column names

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/993 **Author:** [@KamilKopaczyk](https://github.com/KamilKopaczyk) **Created:** 3/28/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`786678c`](https://github.com/doctrine/orm/commit/786678c04fa4e3ca6c2b9070cf4189569274172b) Update JoinColumn.php ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Mapping/JoinColumn.php` (+1 -1) </details> ### 📄 Description If $referencedColumnName = 'id' by default, it doesn't make sense to make checks like: ``` php if (empty($joinColumn['referencedColumnName'])) { ``` (ClassMetaDataInfo file) --- Considering you map your column ``` @ORM\JoinColumn(onDelete="CASCADE") ``` You'll get JoinColumn with 'id' value, which doesn't let doctrine use naming strategies for referenced column names --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:02:46 +01:00

admin closed this issue

2026-01-22 16:02:46 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#9011