doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #960] [MERGED] allow passing EntityManagerInterface when creating a HelperSet #8965

New Issue
Open
opened 2026-01-22 16:02:31 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:02:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/960
Author: @drealecs
Created: 2/23/2014
Status: ✅ Merged
Merged: 3/23/2014
Merged by: @beberlei

Base: master ← Head: fixes-EntityManagerInterface

📝 Commits (1)

  • 1fe6dbc allow passing EntityManagerInterface when creating a HelperSet

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/Console/ConsoleRunner.php (+3 -3)

📄 Description

I've was "extending" EntityManager by decoration-wrapping and was trying to pass my EntityManager to ConsoleRunner::createHelperSet() and the type-hinting didn't allow it.
This fix will allow the $entityManager parameter to be an instance of EntityManagerInterface instead of EntityManager

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/960 **Author:** [@drealecs](https://github.com/drealecs) **Created:** 2/23/2014 **Status:** ✅ Merged **Merged:** 3/23/2014 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `fixes-EntityManagerInterface` --- ### 📝 Commits (1) - [`1fe6dbc`](https://github.com/doctrine/orm/commit/1fe6dbc1f24e40a1c76d00de3f5114bd41ad561a) allow passing EntityManagerInterface when creating a HelperSet ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/Console/ConsoleRunner.php` (+3 -3) </details> ### 📄 Description I've was "extending" EntityManager by decoration-wrapping and was trying to pass my EntityManager to `ConsoleRunner::createHelperSet()` and the type-hinting didn't allow it. This fix will allow the `$entityManager` parameter to be an instance of `EntityManagerInterface` instead of `EntityManager` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8965
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?