doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-24 06:52:09 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #954] [CLOSED] Multi Get support for Second Level Cache #8955

New Issue
Closed
opened 2026-01-22 16:02:29 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:02:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/954
Author: @goetas
Created: 2/14/2014
Status: ❌ Closed

Base: master ← Head: multiget

📝 Commits (9)

  • 08d5e70 Added multi-get support for second level cached collections
  • 7748716 Added test case for MultiGetRegion
  • cb9e1de Added test case for buildCachedCollectioHydrator on DefaultCacheFactory
  • 10331a5 Added dependency with doctrine/cache 1.4
  • 4c3fbee Removed dependency with Region interface
  • c131e32 MultiGetCollectionHydrator depends knows the multi-get region
  • 0b57935 Test suite: Second level cache listener should not mark "cacheable" versioned associations
  • b90576c New buildCacheEntry way bo build a entry for a cached collection
  • 7494d2d Changed some tests to be compatible with the new implementation of

📊 Changes

10 files changed (+187 additions, -17 deletions)

View changed files

📝 composer.json (+1 -0)
📝 lib/Doctrine/ORM/Cache/DefaultCacheFactory.php (+8 -2)
📝 lib/Doctrine/ORM/Cache/DefaultCollectionHydrator.php (+14 -7)
➕ lib/Doctrine/ORM/Cache/MultiGetRegion.php (+41 -0)
📝 lib/Doctrine/ORM/Cache/Persister/Collection/AbstractCollectionPersister.php (+1 -2)
➕ lib/Doctrine/ORM/Cache/Region/DefaultMultiGetRegion.php (+60 -0)
📝 tests/Doctrine/Tests/EventListener/CacheMetadataListener.php (+16 -2)
📝 tests/Doctrine/Tests/ORM/Cache/DefaultCacheFactoryTest.php (+1 -1)
📝 tests/Doctrine/Tests/ORM/Cache/DefaultCollectionHydratorTest.php (+4 -3)
➕ tests/Doctrine/Tests/ORM/Cache/MultiGetRegionTest.php (+41 -0)

📄 Description

Hi!
As discussed here i have implemented some kind of multi-get for second level cache implementation.

I have also created a PR to doctrine/cache component (see https://github.com/doctrine/cache/pull/29) that enables this feature at driver cache level.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/954 **Author:** [@goetas](https://github.com/goetas) **Created:** 2/14/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `multiget` --- ### 📝 Commits (9) - [`08d5e70`](https://github.com/doctrine/orm/commit/08d5e700d9ba53fb0031c0efd47da433d93eb82b) Added multi-get support for second level cached collections - [`7748716`](https://github.com/doctrine/orm/commit/77487162d554e99d944699e88e2c4d445d2d0d06) Added test case for MultiGetRegion - [`cb9e1de`](https://github.com/doctrine/orm/commit/cb9e1de259a8c740bca501e110001608a55876a5) Added test case for buildCachedCollectioHydrator on DefaultCacheFactory - [`10331a5`](https://github.com/doctrine/orm/commit/10331a59e1cc3099d691f450f2a0691390555c30) Added dependency with doctrine/cache 1.4 - [`4c3fbee`](https://github.com/doctrine/orm/commit/4c3fbeecc99568e594a1610a302670b217fcb915) Removed dependency with Region interface - [`c131e32`](https://github.com/doctrine/orm/commit/c131e32362be8e674c5a5f1f7f74fdd9cf14b072) MultiGetCollectionHydrator depends knows the multi-get region - [`0b57935`](https://github.com/doctrine/orm/commit/0b5793582018a7580eaf5eb481dee9ffdfbc9568) Test suite: Second level cache listener should not mark "cacheable" versioned associations - [`b90576c`](https://github.com/doctrine/orm/commit/b90576c9fd9e907c572620311f8fa846ec68719d) New buildCacheEntry way bo build a entry for a cached collection - [`7494d2d`](https://github.com/doctrine/orm/commit/7494d2d970e42ef876a9700402dc897468cdbef8) Changed some tests to be compatible with the new implementation of ### 📊 Changes **10 files changed** (+187 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -0) 📝 `lib/Doctrine/ORM/Cache/DefaultCacheFactory.php` (+8 -2) 📝 `lib/Doctrine/ORM/Cache/DefaultCollectionHydrator.php` (+14 -7) ➕ `lib/Doctrine/ORM/Cache/MultiGetRegion.php` (+41 -0) 📝 `lib/Doctrine/ORM/Cache/Persister/Collection/AbstractCollectionPersister.php` (+1 -2) ➕ `lib/Doctrine/ORM/Cache/Region/DefaultMultiGetRegion.php` (+60 -0) 📝 `tests/Doctrine/Tests/EventListener/CacheMetadataListener.php` (+16 -2) 📝 `tests/Doctrine/Tests/ORM/Cache/DefaultCacheFactoryTest.php` (+1 -1) 📝 `tests/Doctrine/Tests/ORM/Cache/DefaultCollectionHydratorTest.php` (+4 -3) ➕ `tests/Doctrine/Tests/ORM/Cache/MultiGetRegionTest.php` (+41 -0) </details> ### 📄 Description Hi! As discussed [here](http://www.doctrine-project.org/jira/browse/DDC-2981) i have implemented some kind of multi-get for second level cache implementation. I have also created a PR to doctrine/cache component (see https://github.com/doctrine/cache/pull/29) that enables this feature at driver cache level. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:29 +01:00
admin closed this issue 2026-01-22 16:02:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8955
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?