[PR #935] [MERGED] Remove incorrect (outdated) validation for public fields in SchemaValidator #8923

New Issue

admin · 2026-01-22T16:02:20+01:00

admin commented

2026-01-22 16:02:20 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/935
Author: @da-eto
Created: 2/6/2014
Status: ✅ Merged
Merged: 2/19/2014
Merged by: @Ocramius

Base: master ← Head: remove_public_validation

📝 Commits (1)

1f3290f Remove incorrect (outdated) validation for public fields in SchemaValidator

📊 Changes

2 files changed (+0 additions, -20 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/SchemaValidator.php (+0 -14)
📝 tests/Doctrine/Tests/ORM/Functional/SchemaValidatorTest.php (+0 -6)

📄 Description

Doctrine 2.4 now supports proxy objects for entites with public properties. But SchemaValidator still checks that mapped properties in entities should be private or protected. Can we omit this validation?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/935 **Author:** [@da-eto](https://github.com/da-eto) **Created:** 2/6/2014 **Status:** ✅ Merged **Merged:** 2/19/2014 **Merged by:** [@Ocramius](https://github.com/Ocramius) **Base:** `master` ← **Head:** `remove_public_validation` --- ### 📝 Commits (1) - [`1f3290f`](https://github.com/doctrine/orm/commit/1f3290faae37605bf784c6c154372378ad3a11c3) Remove incorrect (outdated) validation for public fields in SchemaValidator ### 📊 Changes **2 files changed** (+0 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/SchemaValidator.php` (+0 -14) 📝 `tests/Doctrine/Tests/ORM/Functional/SchemaValidatorTest.php` (+0 -6) </details> ### 📄 Description Doctrine 2.4 now supports proxy objects for entites with public properties. But SchemaValidator still checks that mapped properties in entities should be private or protected. Can we omit this validation? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:02:20 +01:00

admin closed this issue

2026-01-22 16:02:20 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8923