doctrine/archived-orm
1
0
Fork 0
mirror of https://github.com/doctrine/orm.git synced 2026-03-23 22:42:18 +01:00
Code Issues 5.3k Packages Projects Releases 100 Wiki Activity

[PR #934] [MERGED] faild test with multiple HINT_CUSTOM_TREE_WALKERS #8921

New Issue
Open
opened 2026-01-22 16:02:20 +01:00 by admin · 0 comments
admin commented 2026-01-22 16:02:20 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/934
Author: @shustrik
Created: 2/5/2014
Status: ✅ Merged
Merged: 2/8/2014
Merged by: @beberlei

Base: master ← Head: master

📝 Commits (6)

📊 Changes

3 files changed (+193 additions, -4 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/TreeWalkerChain.php (+4 -3)
➕ lib/Doctrine/ORM/Query/TreeWalkerChainIterator.php (+139 -0)
📝 tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersTest.php (+50 -1)

📄 Description

This PR contains failed test when we have more than 1 HINT_CUSTOM_TREE_WALKERS ,
because walkSelectStatement in TreeWalkerChain saves only last hint _queryComponents result. Could you, please, help to resolve this issue or fix it?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/934 **Author:** [@shustrik](https://github.com/shustrik) **Created:** 2/5/2014 **Status:** ✅ Merged **Merged:** 2/8/2014 **Merged by:** [@beberlei](https://github.com/beberlei) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`7107a85`](https://github.com/doctrine/orm/commit/7107a85041a38f2be8afce4e372a67e586315f98) faild test with multiple HINT_CUSTOM_TREE_WALKERS - [`543ab50`](https://github.com/doctrine/orm/commit/543ab500da014fa8afef0eb2b4d540908e9e65a1) rename test - [`a6b43b9`](https://github.com/doctrine/orm/commit/a6b43b93ace3a04af9ca41d3afc9670df155e266) fix TreeWalkerChain. - [`6fe40b0`](https://github.com/doctrine/orm/commit/6fe40b055fe70db755f91316299002000aad3756) fix return walker - [`12985b7`](https://github.com/doctrine/orm/commit/12985b7811bd63039c0505d22b4cb9f70aedb9b2) add iterator to tree walker chain - [`b167a64`](https://github.com/doctrine/orm/commit/b167a64544f01f6097fa1bf33d32d0a1b5d6c6b9) remove doc ### 📊 Changes **3 files changed** (+193 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/TreeWalkerChain.php` (+4 -3) ➕ `lib/Doctrine/ORM/Query/TreeWalkerChainIterator.php` (+139 -0) 📝 `tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersTest.php` (+50 -1) </details> ### 📄 Description This PR contains failed test when we have more than 1 HINT_CUSTOM_TREE_WALKERS , because walkSelectStatement in TreeWalkerChain saves only last hint _queryComponents result. Could you, please, help to resolve this issue or fix it? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
BC Break
Bug
Can't Fix
Deprecation
Documentation
DQL
Duplicate
Failing Test
Hacktoberfest
Improvement
Improvement
Incomplete
Invalid
Missing Tests
New Feature
PR Created
pull-request
Mirrored from GitHub Pull Request
 Question
Regression
Status: Waiting feedback
Waiting feedback
WIP
Won't Fix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8921
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?