[PR #933] [CLOSED] [POC] [DO NOT MERGE] DDC-2953 #8920

New Issue

admin · 2026-01-22T16:02:19+01:00

admin commented

2026-01-22 16:02:19 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/933
Author: @Ocramius
Created: 2/5/2014
Status: ❌ Closed

Base: master ← Head: hotfix/DDC-2953

📝 Commits (8)

4280df8 DDC-2953 - stubbing out failing test case
b80e8dc DDC-2953 - Fixed tests, reproduced issue
2b14c03 DDC-2953 - schema creation is not needed
f2c92c6 DDC-2953 - cleaning up tests
7940ad6 DDC-2953 - Applying hotfix fas of mariusz.jaskolka@comarch.pl's suggestion
821116c DDC-2953 - removing unused array initialization
c14c7ad DDC-2953 - removing hacky storage of identifier groups indexes
e2ca13b DDC-2953 - identifier groups should be reset at each hydrator preparation

📊 Changes

2 files changed (+135 additions, -15 deletions)

View changed files

📝 lib/Doctrine/ORM/Internal/Hydration/ArrayHydrator.php (+46 -15)
➕ tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2953Test.php (+89 -0)

📄 Description

This PR tries to fix DDC-2953 (http://www.doctrine-project.org/jira/browse/DDC-2953).

tl;dr: when the results are not sorted by root entity identifier, the array hydrator swallows some output.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/933 **Author:** [@Ocramius](https://github.com/Ocramius) **Created:** 2/5/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `hotfix/DDC-2953` --- ### 📝 Commits (8) - [`4280df8`](https://github.com/doctrine/orm/commit/4280df8942e77259c4659d4b49256a1be8e3b878) DDC-2953 - stubbing out failing test case - [`b80e8dc`](https://github.com/doctrine/orm/commit/b80e8dcc657beca4fcf6844e503449efaf9bcb9a) DDC-2953 - Fixed tests, reproduced issue - [`2b14c03`](https://github.com/doctrine/orm/commit/2b14c034cfbf06f7aa71cecf890031dfd03f2fd5) DDC-2953 - schema creation is not needed - [`f2c92c6`](https://github.com/doctrine/orm/commit/f2c92c607e1394eb49bfed816fc2555853c85531) DDC-2953 - cleaning up tests - [`7940ad6`](https://github.com/doctrine/orm/commit/7940ad6f27b5b188de55ca4104e3ed36c7471351) DDC-2953 - Applying hotfix fas of mariusz.jaskolka@comarch.pl's suggestion - [`821116c`](https://github.com/doctrine/orm/commit/821116c7b28c5b2e620ff2c94d9b3f752173aba5) DDC-2953 - removing unused array initialization - [`c14c7ad`](https://github.com/doctrine/orm/commit/c14c7ad4a71566188cfcace06c06df616a6e5bb4) DDC-2953 - removing hacky storage of identifier groups indexes - [`e2ca13b`](https://github.com/doctrine/orm/commit/e2ca13b4eb57d04f8c37c8b69a4460cd788d606c) DDC-2953 - identifier groups should be reset at each hydrator preparation ### 📊 Changes **2 files changed** (+135 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Internal/Hydration/ArrayHydrator.php` (+46 -15) ➕ `tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2953Test.php` (+89 -0) </details> ### 📄 Description This PR tries to fix DDC-2953 (http://www.doctrine-project.org/jira/browse/DDC-2953). tl;dr: when the results are not sorted by root entity identifier, the array hydrator swallows some output. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:02:19 +01:00

admin closed this issue

2026-01-22 16:02:20 +01:00

admin referenced this issue

2026-01-22 16:10:11 +01:00

[PR #8920] Avoid returning null from `EntityManager::getReference()` and `getPartialReference()` #11257

Sign in to join this conversation.