[PR #930] Transactional callback isn't returning false #8917

New Issue

admin · 2026-01-22T16:02:18+01:00

admin commented

2026-01-22 16:02:18 +01:00

Original Pull Request: https://github.com/doctrine/orm/pull/930

State: closed
Merged: No

Trying to fix any situation that if we've something callback with explicit FALSE return, like:

$rtn = $mgr->transactional(function() {...; return false;});
$rtn //true

Should be the return value of the callback method,
If the method is not returning any value (null), then.. we consider the callback was done, then return true.

Regards.

**Original Pull Request:** https://github.com/doctrine/orm/pull/930 **State:** closed **Merged:** No --- Trying to fix any situation that if we've something callback with explicit FALSE return, like: ``` php $rtn = $mgr->transactional(function() {...; return false;}); $rtn //true ``` Should be the return value of the callback method, If the method is not returning any value (null), then.. we consider the callback was done, then return true. Regards.

admin added the pull-request label 2026-01-22 16:02:18 +01:00

admin referenced this issue

2026-01-22 16:10:11 +01:00

[PR #8917] Assert action is not null #11255

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8917