[PR #896] [MERGED] Ensure <cascade/> elements preceed <join-columns/> #8864

Closed
opened 2026-01-22 16:02:02 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/896
Author: @holtkamp
Created: 1/5/2014
Status: Merged
Merged: 1/5/2014
Merged by: @guilhermeblanco

Base: masterHead: patch-2


📝 Commits (1)

📊 Changes

1 file changed (+33 additions, -33 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/Export/Driver/XmlExporter.php (+33 -33)

📄 Description

When converting annotations based metadata to XML, the position of the <cascade/> elements in the generated files resulted in XSD validation errors caused by the definitions of the association ComplexTypes:

Since changing the XSD might result in validation problems in existing mappings, changing the XmlExporter seems a better approach.

Note that the <cache/> element is not yet generated by the XmlExporter, but according to the XML Schema, it should precede the <cascade/> element.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/896 **Author:** [@holtkamp](https://github.com/holtkamp) **Created:** 1/5/2014 **Status:** ✅ Merged **Merged:** 1/5/2014 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`85a16f9`](https://github.com/doctrine/orm/commit/85a16f9f28b33111139443d0047175dfb245506d) Ensure <cascade/> elements preceed <join-columns/> ### 📊 Changes **1 file changed** (+33 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/Export/Driver/XmlExporter.php` (+33 -33) </details> ### 📄 Description When converting annotations based metadata to XML, the position of the `<cascade/>` elements in the generated files resulted in XSD validation errors caused by the definitions of the association ComplexTypes: - https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L463 - https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L482 - https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L495 - https://github.com/doctrine/doctrine2/blob/master/doctrine-mapping.xsd#L517 Since changing the XSD might result in validation problems in existing mappings, changing the XmlExporter seems a better approach. Note that the `<cache/>` element is not yet generated by the XmlExporter, but according to the XML Schema, it should precede the `<cascade/>` element. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:02:02 +01:00
admin closed this issue 2026-01-22 16:02:03 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8864