[PR #793] [MERGED] Improved error messages in Paginator: LimitSubqueryOutputWalker #8719

New Issue

admin · 2026-01-22T16:01:14+01:00

admin commented

2026-01-22 16:01:14 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/793
Author: @flip111
Created: 9/17/2013
Status: ✅ Merged
Merged: 9/30/2013
Merged by: @guilhermeblanco

Base: master ← Head: patch-2

📝 Commits (2)

b803f06 Improved error messages in Paginator: LimitSubqueryOutputWalker
a18aba1 Improved error messages in Paginator: LimitSubqueryOutputWalker

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php (+4 -0)

📄 Description

The already existing follow-up check throwing "Not all identifier properties can be found in the ResultSetMapping: %s" is a much more technical description.

If $sqlIdentifier is empty (count 0) it can be concluded that there are no mapped results. An alternative error message could thus be "The Paginator does not support queries without mapped results." (line 153).

Possibly '!=' on line 154 could be replaced by '>' because i think this is the only situation that can occur. But since i don't know this for sure, i left it like i found it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/793 **Author:** [@flip111](https://github.com/flip111) **Created:** 9/17/2013 **Status:** ✅ Merged **Merged:** 9/30/2013 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (2) - [`b803f06`](https://github.com/doctrine/orm/commit/b803f06c8f3c518b1a6fef19aba1ec61c69722c8) Improved error messages in Paginator: LimitSubqueryOutputWalker - [`a18aba1`](https://github.com/doctrine/orm/commit/a18aba1bb694d418f6b13e8deeef7f5e31777c9f) Improved error messages in Paginator: LimitSubqueryOutputWalker ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php` (+4 -0) </details> ### 📄 Description The already existing follow-up check throwing "Not all identifier properties can be found in the ResultSetMapping: %s" is a much more technical description. If $sqlIdentifier is empty (count 0) it can be concluded that there are no mapped results. An alternative error message could thus be "The Paginator does not support queries without mapped results." (line 153). Possibly '!=' on line 154 could be replaced by '>' because i think this is the only situation that can occur. But since i don't know this for sure, i left it like i found it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:01:14 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8719