mirror of
https://github.com/doctrine/orm.git
synced 2026-03-24 06:52:09 +01:00
[PR #753] JoinedSubclassPersister doesn't properly bind on some versions of php #8665
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/doctrine/orm/pull/753
State: closed
Merged: Yes
I ran into this bug after deploying an application to production:
The parent table is being inserted properly (It's where the single param 4 comes from for the id), but the child table insert fails.
This was on a shared host with PHP version 5.3.24. On my development machine, everything works fine.
The issue is when the id is not a composite key, it's just a string (in this case), and for whatever reason !isset($id[$columnName]) fails to return a sane value on my production version of php.
By adding a check to see if the ID is an array we can determine if its a composite key, and not bother with the column checks if its not.
Not sure how to write unit tests for this one since it only affects certain versions of PHP (apparently). So advice on that is appreciated.