[PR #691] [MERGED] IDENTITY function fix for Joined Inheritance #8563

Open
opened 2026-01-22 16:00:32 +01:00 by admin · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/691
Author: @powturns
Created: 6/12/2013
Status: Merged
Merged: 6/12/2013
Merged by: @guilhermeblanco

Base: masterHead: master


📝 Commits (2)

  • 529064a Modified identity function to work with joined inheritance tables.
  • ed7a4bd Fix typo in test name

📊 Changes

2 files changed (+19 additions, -1 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/AST/Functions/IdentityFunction.php (+4 -1)
📝 tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php (+15 -0)

📄 Description

In a joined inheritance scenario, the identity function implementation assumed the foreign key column was on the table corresponding to the (sub)class named in the select statement. If the relation was on a super-class incorrect sql was generated.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/691 **Author:** [@powturns](https://github.com/powturns) **Created:** 6/12/2013 **Status:** ✅ Merged **Merged:** 6/12/2013 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`529064a`](https://github.com/doctrine/orm/commit/529064aff2cffb71580ee64f6fb4bb4b7f145b7e) Modified identity function to work with joined inheritance tables. - [`ed7a4bd`](https://github.com/doctrine/orm/commit/ed7a4bdcf3897b91b39b1b3b281cea2e4a406fbc) Fix typo in test name ### 📊 Changes **2 files changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/AST/Functions/IdentityFunction.php` (+4 -1) 📝 `tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php` (+15 -0) </details> ### 📄 Description In a joined inheritance scenario, the identity function implementation assumed the foreign key column was on the table corresponding to the (sub)class named in the select statement. If the relation was on a super-class incorrect sql was generated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
admin added the pull-request label 2026-01-22 16:00:32 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8563