[PR #688] [MERGED] Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration #8561

New Issue

admin · 2026-01-22T16:00:32+01:00

admin commented

2026-01-22 16:00:32 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/688
Author: @johnbrown
Created: 6/6/2013
Status: ✅ Merged
Merged: 6/12/2013
Merged by: @guilhermeblanco

Base: master ← Head: master

📝 Commits (4)

77b905e Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration
9bea612 Adding simple test to ensure quoting of table names still functions. Note: the funtionality of this change won't be noticiable unless a custom quote strategy is implemented
afb9c82 updating sql walker to use quote strategy in joins
4ef043f updating sql walker to use quote strategy in joins

📊 Changes

2 files changed (+15 additions, -4 deletions)

View changed files

📝 lib/Doctrine/ORM/Query/SqlWalker.php (+4 -4)
📝 tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php (+11 -0)

📄 Description

Based on:
http://www.doctrine-project.org/jira/browse/DDC-1845
cb72219b11

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/688 **Author:** [@johnbrown](https://github.com/johnbrown) **Created:** 6/6/2013 **Status:** ✅ Merged **Merged:** 6/12/2013 **Merged by:** [@guilhermeblanco](https://github.com/guilhermeblanco) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`77b905e`](https://github.com/doctrine/orm/commit/77b905eaa890bb0915642ef37e4c5eb3b5cfaefb) Implement QuoteStrategy on SqlWalker walkRangeVariableDeclaration - [`9bea612`](https://github.com/doctrine/orm/commit/9bea612d7405c90ac979f41171b0257d2c49d31b) Adding simple test to ensure quoting of table names still functions. Note: the funtionality of this change won't be noticiable unless a custom quote strategy is implemented - [`afb9c82`](https://github.com/doctrine/orm/commit/afb9c829e2fb2395924d1064a47a2ac2f64883e0) updating sql walker to use quote strategy in joins - [`4ef043f`](https://github.com/doctrine/orm/commit/4ef043fc3b05f8f610a211d597e802c9c8131c16) updating sql walker to use quote strategy in joins ### 📊 Changes **2 files changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/Query/SqlWalker.php` (+4 -4) 📝 `tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php` (+11 -0) </details> ### 📄 Description Based on: http://www.doctrine-project.org/jira/browse/DDC-1845 https://github.com/doctrine/doctrine2/commit/cb72219b118c158c9b5344c4b81ff2b1a9149ab0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:00:32 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8561