[PR #643] [CLOSED] DDC-2390: Remove Query dependency in SqlWalker and Parser #8500

New Issue

admin · 2026-01-22T16:00:11+01:00

admin commented

2026-01-22 16:00:11 +01:00

📋 Pull Request Information

Original PR: https://github.com/doctrine/orm/pull/643
Author: @beberlei
Created: 4/4/2013
Status: ❌ Closed

Base: master ← Head: DDC-2390

📝 Commits (2)

0960711 [DDC-2390] Introduce MetadataBag and delegate all calls from AbstractQuery and Query.
a9639ae [DDC-2390] Remove Query dependency from SqlWalker (and all TreeWalkers) and Parser

📊 Changes

12 files changed (+303 additions, -143 deletions)

View changed files

📝 lib/Doctrine/ORM/AbstractQuery.php (+23 -31)
📝 lib/Doctrine/ORM/Query.php (+10 -27)
➕ lib/Doctrine/ORM/Query/MetadataBag.php (+166 -0)
📝 lib/Doctrine/ORM/Query/Parser.php (+15 -8)
📝 lib/Doctrine/ORM/Query/SqlWalker.php (+3 -3)
📝 lib/Doctrine/ORM/Query/TreeWalker.php (+1 -1)
📝 lib/Doctrine/ORM/Query/TreeWalkerAdapter.php (+12 -1)
📝 lib/Doctrine/ORM/Query/TreeWalkerChain.php (+59 -58)
📝 lib/Doctrine/ORM/Tools/Pagination/CountOutputWalker.php (+3 -3)
📝 lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php (+5 -4)
📝 tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersJoinTest.php (+2 -2)
📝 tests/Doctrine/Tests/ORM/Query/LanguageRecognitionTest.php (+4 -5)

📄 Description

To prevent future problems with illegal Query parameter access and also to decouple the namespaces by removing bidirectional dependency.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/doctrine/orm/pull/643 **Author:** [@beberlei](https://github.com/beberlei) **Created:** 4/4/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `DDC-2390` --- ### 📝 Commits (2) - [`0960711`](https://github.com/doctrine/orm/commit/096071144dc1b6356065a650189c6e38c1903cc6) [DDC-2390] Introduce MetadataBag and delegate all calls from AbstractQuery and Query. - [`a9639ae`](https://github.com/doctrine/orm/commit/a9639ae300a838a69cf8ce7a37f664349b73b657) [DDC-2390] Remove Query dependency from SqlWalker (and all TreeWalkers) and Parser ### 📊 Changes **12 files changed** (+303 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `lib/Doctrine/ORM/AbstractQuery.php` (+23 -31) 📝 `lib/Doctrine/ORM/Query.php` (+10 -27) ➕ `lib/Doctrine/ORM/Query/MetadataBag.php` (+166 -0) 📝 `lib/Doctrine/ORM/Query/Parser.php` (+15 -8) 📝 `lib/Doctrine/ORM/Query/SqlWalker.php` (+3 -3) 📝 `lib/Doctrine/ORM/Query/TreeWalker.php` (+1 -1) 📝 `lib/Doctrine/ORM/Query/TreeWalkerAdapter.php` (+12 -1) 📝 `lib/Doctrine/ORM/Query/TreeWalkerChain.php` (+59 -58) 📝 `lib/Doctrine/ORM/Tools/Pagination/CountOutputWalker.php` (+3 -3) 📝 `lib/Doctrine/ORM/Tools/Pagination/LimitSubqueryOutputWalker.php` (+5 -4) 📝 `tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersJoinTest.php` (+2 -2) 📝 `tests/Doctrine/Tests/ORM/Query/LanguageRecognitionTest.php` (+4 -5) </details> ### 📄 Description To prevent future problems with illegal Query parameter access and also to decouple the namespaces by removing bidirectional dependency. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

admin added the pull-request label 2026-01-22 16:00:11 +01:00

admin referenced this issue

2026-01-22 16:09:28 +01:00

[PR #8500] Proposed fix for #DCC8499 #11024

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: doctrine/archived-orm#8500